🐛 Fix ancillary handling in ZX checker#512
Conversation
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Disables ZX Checker when non-garbage ancillae are defined.
Signed-off-by: Tom Peham <[email protected]>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
…ebugging-ancilla-qubits
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
left a comment
There was a problem hiding this comment.
@pehamTom many thanks for the changes here. I pushed a couple of commits with cleanups of unrelated changes and a small fix for an oversight in the new shortcut of the ZX Checker run method.
I only have two real questions left, which you will find inline.
Other than that, it would be nice if you could add a changelog entry for this fix.
…ebugging-ancilla-qubits
…ebugging-ancilla-qubits
…ebugging-ancilla-qubits
burgholzer
left a comment
There was a problem hiding this comment.
Thanks @pehamTom for the further iteration here. I think we need one more iteration and then this should be done for good. You'll find the detailed comments inline.
Co-authored-by: Lukas Burgholzer <[email protected]> Signed-off-by: Tom Peham <[email protected]>
…ebugging-ancilla-qubits
…ebugging-ancilla-qubits
Signed-off-by: Tom Peham <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Description
Fixes #508
The regression tests and the corresponding CI failures demonstrate the underlying issue in the ZX checkers:
equivalent, while all other checkers agree that the two circuits are not equivalent.Note the first two tests fail for separate reasons, which means there are multiple things going wrong here.
This PR adjusts the conditions under which the ZX checker declares it can handle the underlying circuits, making it more conservative than before.
Additionally, the out of range error is fixed.
Checklist: