Synthesis of shift expressions with shift amount larger or equal to bitwidth of to be shift expression.

[TooMuchDakka]

Description

With this PR the synthesis of a shift expression in which the defined shift amount is larger or equal to the bitwidth of the to be shifted expression (N) is "simplified" to the creation of N ancillary qubits (i.e. equal to an substitution of the shift expression with the constant 0) with the latter storing the result of the shift expression.

Fixes #258

Checklist:

• The pull request only contains commits that are related to it.
• I have added appropriate tests and documentation.
• I have made sure that all CI jobs on GitHub pass.
• The pull request introduces no new warnings and follows the project's style guidelines.

[github-advanced-security]

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[burgholzer]

LGTM

[Copilot]

Pull Request Overview

This PR enhances the synthesis of shift expressions by optimizing cases where the shift amount is greater than or equal to the bitwidth of the shifted expression. In such cases, the result is mathematically equivalent to zero, so the PR simplifies the synthesis to create N ancillary qubits (where N is the bitwidth) instead of performing the actual shift operation.

• Fixes #258 by optimizing shift expressions with large shift amounts
• Updates synthesis logic to return early when shift amount >= bitwidth
• Improves parameter naming for better code clarity

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
test/unittests/simulation/test_synthesis_basic_operations.cpp	Adds comprehensive test cases for shift expression synthesis edge cases
test/unittests/simulation/data/test_synthesis_of_basic_operations.json	Provides test data for all new shift expression test cases
src/algorithms/synthesis/syrec_synthesis.cpp	Implements the optimization logic and improves parameter naming
include/algorithms/synthesis/syrec_synthesis.hpp	Updates function signatures with more descriptive parameter names