Skip to content

♻️ Update outdated filter after restructuring MQT repos #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

ystade
Copy link
Contributor

@ystade ystade commented Jun 3, 2025

Description

We are about to restructure our MQT repos such that code belonging to Python bindings resites at a different location, i.e., all bindings-related code is moved to a top-level bindings/ directory and all Python files go into a top-level python/ directory. The PR #982 in MQT Core demonstrates that for MQT Core and #624 in MQT QMAP for MQT QMAP.

Hence, some filters in the change detection workflow become obsolete and should be updated. I included a first proposal for that update but I am not 100% certain whether this covers everything. Let's consolidate within this PR.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@ystade ystade self-assigned this Jun 3, 2025
@ystade ystade added c++ Anything related to C++ code continuous integration Anything related to the CI setup fix Fix for something that is not working python Anything related to Python code labels Jun 3, 2025
@ystade ystade requested a review from burgholzer June 3, 2025 12:47
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the changes here look reasonable and practically complete! Thanks @ystade!
I just have one comment that we should all be aware of.

This is assuming that we stick with the currently proposed changes and do not refine the structure further. (e.g., moving Python tests to python/tests)

@ystade ystade added the minor Part of a minor release label Jun 3, 2025
@ystade ystade merged commit 10a252b into main Jun 3, 2025
4 checks passed
@ystade ystade deleted the update-filter branch June 3, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code continuous integration Anything related to the CI setup fix Fix for something that is not working minor Part of a minor release python Anything related to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants