-
Notifications
You must be signed in to change notification settings - Fork 2
Fix linter #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linter #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What. This is something to look into further.
What you are doing here is exactly what the setup-uv option should accomplish.
Besides that, this PR contains some extra commits from the other branch apparently.
Oops, sorry. The other commits should not have been part of this PR here. They are removed now. The issue is, that the |
The issue is that one apparently can neither tell cpp-linter to use the existing venv nor to tell uv-setup how the virtual environment should be called. |
Ah. That makes more sense now. |
- if: ${{ inputs.setup-python }} | ||
name: Create virtual environment | ||
run: | | ||
${{ steps.setup-python.outputs.python-path }} -m venv venv |
Check warning
Code scanning / CodeQL
Code injection Medium
${ steps.setup-python.outputs.python-path }
Ok, this PR became superfluous. The workflow works just fine, there is no bug in the workflow. THe issue in the other PRs using this workflow were caused by a typo, i.e., |
Description
This PR fixes an issue that was only discovered in #982 in MQT Core. Before,
pybind11
was installed in a different python environment than later used during the run ofcpp-linter
. Now, we use the same env.Checklist: