Skip to content

👷 Use GitHub App token for workflow that updates MQT Core #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 8, 2025

Conversation

denialhaag
Copy link
Contributor

@denialhaag denialhaag commented Jul 7, 2025

Description

This PR changes the reusable update-mqt-core workflow so that it creates the PR using a GitHub App token.

This change requires an update in the repositories using the workflow. For an exemplary PR updating the usage, see munich-quantum-toolkit/qmap#689.

For more information on using secrets in reusable workflows, see the documentation.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Jul 7, 2025
@denialhaag denialhaag changed the title Make token an input for update workflow 👷 Make token an input for workflow that updates MQT Core Jul 7, 2025
@denialhaag denialhaag changed the title 👷 Make token an input for workflow that updates MQT Core 👷 Use GitHub App token for workflow that updates MQT Core Jul 7, 2025
@denialhaag
Copy link
Contributor Author

@burgholzer, which other repositories use this reusable workflow and need an update? 🤔

@burgholzer burgholzer added continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file minor Part of a minor release labels Jul 8, 2025
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Many thanks.
I just tagged this with the "minor" label, because it will require updates in consuming workflows.

Would you mind adding a respective Changelog entry and an upgrade guide notice?

@burgholzer
Copy link
Member

@burgholzer, which other repositories use this reusable workflow and need an update? 🤔

Basically all C++ repositories using mqt-core. That should be

  • QCEC
  • QMAP
  • DDSIM
  • DDVIS
  • SyReC
  • Debugger

@denialhaag
Copy link
Contributor Author

This looks great. Many thanks. I just tagged this with the "minor" label, because it will require updates in consuming workflows.

Would you mind adding a respective Changelog entry and an upgrade guide notice?

Done!

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a minor suggestion for the upgrade guide note. I'll quickly apply that and then this should be good to go.

Let's briefly take the time to think about whether it would make sense to add further PRs before the next release or whether we should just prepare a new release right now.

burgholzer and others added 2 commits July 8, 2025 10:06
@denialhaag
Copy link
Contributor Author

Let's briefly take the time to think about whether it would make sense to add further PRs before the next release or whether we should just prepare a new release right now.

I think it makes sense to prepare a release now and then wait for the Renovate PRs to include the necessary changes. 🤔

@burgholzer
Copy link
Member

Let's briefly take the time to think about whether it would make sense to add further PRs before the next release or whether we should just prepare a new release right now.

I think it makes sense to prepare a release now and then wait for the Renovate PRs to include the necessary changes. 🤔

Yeah. In that case, I think it makes sense to already prepare that as part of this PR and release right after merging.
That mainly involves adding dedicated sections for the new release in both guides.

@denialhaag
Copy link
Contributor Author

Let's briefly take the time to think about whether it would make sense to add further PRs before the next release or whether we should just prepare a new release right now.

I think it makes sense to prepare a release now and then wait for the Renovate PRs to include the necessary changes. 🤔

Yeah. In that case, I think it makes sense to already prepare that as part of this PR and release right after merging. That mainly involves adding dedicated sections for the new release in both guides.

Perfect! The most recent commit should include the necessary changes. 🤔

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
I'll merge this and trigger the release as soon as the release drafter has run on the main branch.

@burgholzer burgholzer merged commit d589adf into main Jul 8, 2025
4 checks passed
@burgholzer burgholzer deleted the use-app-token branch July 8, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file minor Part of a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants