-
Notifications
You must be signed in to change notification settings - Fork 2
👷 Use GitHub App token for workflow that updates MQT Core #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@burgholzer, which other repositories use this reusable workflow and need an update? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Many thanks.
I just tagged this with the "minor" label, because it will require updates in consuming workflows.
Would you mind adding a respective Changelog entry and an upgrade guide notice?
Basically all C++ repositories using mqt-core. That should be
|
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just a minor suggestion for the upgrade guide note. I'll quickly apply that and then this should be good to go.
Let's briefly take the time to think about whether it would make sense to add further PRs before the next release or whether we should just prepare a new release right now.
Signed-off-by: Lukas Burgholzer <[email protected]>
I think it makes sense to prepare a release now and then wait for the Renovate PRs to include the necessary changes. 🤔 |
Yeah. In that case, I think it makes sense to already prepare that as part of this PR and release right after merging. |
Perfect! The most recent commit should include the necessary changes. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
I'll merge this and trigger the release as soon as the release drafter has run on the main branch.
Description
This PR changes the reusable
update-mqt-core
workflow so that it creates the PR using a GitHub App token.This change requires an update in the repositories using the workflow. For an exemplary PR updating the usage, see munich-quantum-toolkit/qmap#689.
For more information on using secrets in reusable workflows, see the documentation.
Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.