Skip to content

💥 Move matrix generation to calling workflow #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 17, 2025
Merged

Conversation

denialhaag
Copy link
Contributor

@denialhaag denialhaag commented Jul 16, 2025

Description

This PR simplifies some reusable workflows by moving the matrix generation to the calling workflows.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Jul 16, 2025
@denialhaag denialhaag changed the title Move matrix generation to calling workflow 💥 Move matrix generation to calling workflow Jul 16, 2025
@denialhaag denialhaag requested a review from burgholzer July 16, 2025 15:09
@denialhaag denialhaag added the continuous integration Anything related to the CI setup label Jul 16, 2025
@denialhaag denialhaag marked this pull request as ready for review July 16, 2025 15:09
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great already. I just have one comment on the Python testing workflow, which might need some further changes.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I like where this is going. I only have two small little comments that should be fairly easy to address.
Feel free to also directly prepare another release as part of this PR. Should probably be another minor one.

@burgholzer burgholzer added c++ Anything related to C++ code minor Part of a minor release packaging Anything related to Python packaging python Anything related to Python code usability Anything related to usability labels Jul 16, 2025
@denialhaag denialhaag requested a review from burgholzer July 17, 2025 07:41
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's go 🚀

@denialhaag denialhaag merged commit c0f3541 into main Jul 17, 2025
4 checks passed
@denialhaag denialhaag deleted the matrix-strategy branch July 17, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code continuous integration Anything related to the CI setup minor Part of a minor release packaging Anything related to Python packaging python Anything related to Python code usability Anything related to usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants