-
Notifications
You must be signed in to change notification settings - Fork 2
💥 Move matrix generation to calling workflow #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great already. I just have one comment on the Python testing workflow, which might need some further changes.
13b3e7b
to
2a0c3cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I like where this is going. I only have two small little comments that should be fairly easy to address.
Feel free to also directly prepare another release as part of this PR. Should probably be another minor one.
.github/workflows/reusable-python-packaging-wheel-cibuildwheel.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Burgholzer <[email protected]> Signed-off-by: Daniel Haag <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, let's go 🚀
Description
This PR simplifies some reusable workflows by moving the matrix generation to the calling workflows.
Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.