Skip to content

Update/order-converter#16

Draft
nicolapalavecino wants to merge 16 commits intomasterfrom
update/order-converter
Draft

Update/order-converter#16
nicolapalavecino wants to merge 16 commits intomasterfrom
update/order-converter

Conversation

@nicolapalavecino
Copy link
Collaborator

@nicolapalavecino nicolapalavecino commented Jun 7, 2022

Commits description:

  1. Rename legacy order converter
  2. Include code in createApp that will be backward compatible with old apps. If instead, an order converter is defined, it will use that one instead. Legacy converter doesn't really have any implementation change, we just add an ID to identify it as the old version of the converter
  3. Extracting code from legacy that I will reuse in the new one
  4. Extracting code from legacy that I will reuse in the new one
  5. Rearrange old legacy algorithm to be able to be extensible in the future (preparing for converter v2)
  6. Copy & paste the same algorithm to version 2
  7. Add option so you can decide which sort algorithm to use when using the converter
  8. Add the piece missing in the new order converter so it has a more stable sorting
  9. All common logic from both algorithms is extracted to common file
  10. Export new converter 🎉

@nicolapalavecino nicolapalavecino force-pushed the update/order-converter branch 2 times, most recently from 44e47c4 to 26b8a14 Compare June 8, 2022 14:18
@nicolapalavecino nicolapalavecino force-pushed the update/order-converter branch from 7398d36 to 32dd7a3 Compare June 17, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant