Add (initial) support for AirPlay 2 to the AirPlay player provider #2514
Conversation
| await self.mass.config.save_player_config( | ||
| player_id, {CONF_AIRPLAY_VERSION: disc_airplay_version} | ||
| ) |
There was a problem hiding this comment.
this is not allowed, you should instead simply provide a default value in the config entry, not save it yourself from the provider to the config controller.
There was a problem hiding this comment.
ok. Can you please help me with how to do that? I have created a helper function to identify devices which should default to ap2 is_airplay2_model(). It takes the same approach as the broken_raop_model() helper. I suspect that ultimately, we should use one of the txt properties from the _airplay._tcp discovery info to determine whether to use raop or ap2.
There was a problem hiding this comment.
Once the missing arguments are in place so that sync works, I would simply default to airplay 2 if the airplay mdns record is found
marcelveldt
changed the title
|
Marked as draft because this is still a wip and not yet functional |
Co-authored-by: OzGav <[email protected]>
…ck control, progress, volume control, metadata etc not yet implemented.
| content_type=ContentType.from_bit_depth(16), sample_rate=44100, bit_depth=16 | ||
| ) | ||
|
|
||
| BROKEN_RAOP_MODELS = ( |
There was a problem hiding this comment.
we should maybe combine this list with the airplay2 models so we by default enforce them to AP2
There was a problem hiding this comment.
at some point we can rename this constant to "ENFORCE_AIRPLAY_2"
Very likely that the new UniFi PoE Audio Port should also be added. Perhaps wildcard the model?
| ) | ||
|
|
||
| BROKEN_RAOP_MODELS = ( | ||
| # A recent fw update of newer gen Sonos speakers block RAOP (airplay 1) support, |
There was a problem hiding this comment.
Not sure if it’s appropriate now, but “Juke Audio” amplifiers only work with Airplay 2 and not RAOP so perhaps we should add them here as well?
| ("Juke Audio", "*"), | |
| # A recent fw update of newer gen Sonos speakers block RAOP (airplay 1) support, |
|
Superseded by #2571 |
4 participants
Initial work to support a seperate cli binary for AirPlay2 devices.