MailComposer: Save draft in correct folder (#646)

[jermy-c]

• Emails were saving to the initial identity even when the identity is changed
• The mail.folder is now set before saving

[benbucksch]

Instead, in line 241, change ??= to = .

Test various scenarios to make sure it doesn't regress something.

[jermy-c]

Instead, in line 241, change ??= to = .

This works.

I'm getting some errors when deleting the saved draft for EWS. And it seems to be saving a new copy if you're editing the draft.

1. this.folder.account.callEWS is not a function
2. The specified object was not found in the store., The process failed to get the correct properties.

[benbucksch]

Are these bugs new regressions from this change here?

I suspect that we need to check whether the folder changed, and delete the old draft from the old folder.

[jermy-c]

Are these bugs new regressions from this change here?

Yes, it seems to be caused by the folder change.

I suspect that we need to check whether the folder changed, and delete the old draft from the old folder.

Ok, I'll try this.

[NeilRashbrook]

Once you edit a draft, you're changing an email which thinks it knows what its folder and account are, and doesn't take very kindly to having these things changed for it. For instance, the draft folder still has the draft email in its messages list.

From my point of view the ideal solution would be to clone the email and edit that instead, keeping a reference to the original email so that it can be deleted (seems simpler than looking for it).

[jermy-c]

• We were saving the email based on folder.account rather than identity.account, however, our identity.account and folder.account don't match. That's for the saving the email in the wrong identity.

mustang/app/logic/Mail/ComposeActions.ts

Line 249 in f71507f

let account = this.email.folder?.account ?? this.email.identity?.account;

• For the body, we don't regenerate the MIME for the email so edits were not saved.

mustang/app/logic/Mail/IMAP/IMAPFolder.ts

Line 545 in f71507f

message.mime ??= await CreateMIME.getMIME(message);

[benbucksch]

[when opening a draft,] clone the [draft] email and edit that instead, keeping a reference to the original [draft] email so that it can be deleted.

Makes sense. Let's do that.