Skip to content

Settings: About: Download and install app updates #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

benbucksch
Copy link
Collaborator

  • In Settings | About, add a check for updates and an [Install update] button

TODO:

  • Check for update fails. No idea why.
  • The updater API is rather wierd, with the events. We need to unsubscribe the events.

@benbucksch benbucksch self-assigned this Jul 9, 2025
@benbucksch benbucksch marked this pull request as draft July 9, 2025 05:28
@benbucksch benbucksch requested a review from jermy-c July 9, 2025 05:28
@jermy-c
Copy link
Collaborator

jermy-c commented Jul 9, 2025

Check for update fails. No idea why.

If failing means that it's always remains in the Checking for updates…, that is because you need to build the app for the autoUpdater to work. But even when building the app, I get an Error: No published version on GitHub.

@benbucksch
Copy link
Collaborator Author

you mean it's always remains in the Checking for updates…

Yes

you need to build the app for the autoUpdater to work

You mean yarn build or yarn build:release:mac ?

@jermy-c
Copy link
Collaborator

jermy-c commented Jul 9, 2025

You mean yarn build or yarn build:release:mac ?

I normally just do yarn build:mac

@benbucksch
Copy link
Collaborator Author

@jermy-c Can you please finish this PR? Make it work?

(I remember you specifically asked for this a long time ago.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants