fix: background audio handling #1251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SputNikPlop
requested review from
chungwwei,
cswills,
jessielw,
juaoose and
kevmo314
|
Superficially this seems reasonable but I think we should launch the new TTS engine before getting this in. This adds a good amount of complexity and it would be better to simplify TTS and get the new engine out before making it more complex. |
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
Got it, there also is a slight difference between 19ba377 and c1444cd on the audio it seems so later that will have to be sorted to which version is correct |
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
had a problem deploying
to
android-internal
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
GitHub Actions
Failure
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
had a problem deploying
to
android-internal
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should better handle the audio while tts is on, should be tested though.