- 
                Notifications
    You must be signed in to change notification settings 
- Fork 23
fix: quality selector #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: quality selector #1356
Conversation
| Does this actually work? I recall when I implemented the preview, a lot of the resolutions had no effect on the quality of the stream that twitch sent even if the streamer had transcoding resources. | 
| 
 Yes and no, works for partners but really not sure with enhanced broadcasting so lemme leave it open and test when I got time | 
| 
 Ok, the change otherwise seems reasonable. It would be nice if we can detect the list of functional resolutions and switch between those, otherwise the non-partners will end up with a button that does nothing most of the time. | 
| @kevmo314 Ok check the new changes out perhaps it works | 
        
          
                assets/twitch-tunnel.js
              
                Outdated
          
        
      | }; | ||
|  | ||
| // Initialize when Twitch player is ready | ||
| if (typeof Twitch !== 'undefined') { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I tried some new js, let me know if that works bit of a patch work in me understanding whats going on

No description provided.