Skip to content

Conversation

@SputNikPlop
Copy link
Collaborator

No description provided.

@kevmo314
Copy link
Contributor

Does this actually work? I recall when I implemented the preview, a lot of the resolutions had no effect on the quality of the stream that twitch sent even if the streamer had transcoding resources.

@SputNikPlop
Copy link
Collaborator Author

Does this actually work? I recall when I implemented the preview, a lot of the resolutions had no effect on the quality of the stream that twitch sent even if the streamer had transcoding resources.

Yes and no, works for partners but really not sure with enhanced broadcasting so lemme leave it open and test when I got time

@kevmo314
Copy link
Contributor

Does this actually work? I recall when I implemented the preview, a lot of the resolutions had no effect on the quality of the stream that twitch sent even if the streamer had transcoding resources.

Yes and no, works for partners but really not sure with enhanced broadcasting so lemme leave it open and test when I got time

Ok, the change otherwise seems reasonable. It would be nice if we can detect the list of functional resolutions and switch between those, otherwise the non-partners will end up with a button that does nothing most of the time.

@SputNikPlop
Copy link
Collaborator Author

@kevmo314 Ok check the new changes out perhaps it works

};

// Initialize when Twitch player is ready
if (typeof Twitch !== 'undefined') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this exists?

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I tried some new js, let me know if that works bit of a patch work in me understanding whats going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants