Skip to content

chore(dependencies): Update Media3 to 1.5.0 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

EverydayPineapple
Copy link
Contributor

I have a strange issue with the current release of mux-player-android that's forcing me to exclude the Media3 group from my dependencies. I haven't fully traced the issue but it's something to do with the fact that I end up with two versions of some of Media3 and Activities aren't being fully destroyed where they were before. It's very strange.

I've done the following for now

implementation(libs.mux) {
    exclude(group = "androidx.media3") 
  }

... but would be nice not to have to.

I believe the following PR is all you need to update to 1.5.0 but feel free to let me know otherwise.

@EverydayPineapple EverydayPineapple requested a review from a team as a code owner December 16, 2024 17:16
@daytime-em
Copy link
Collaborator

daytime-em commented Dec 17, 2024

@EverydayPineapple Thank you for your contribution! I'll probably be able to get this deployed today.

Just to make sure: Did updating media3 to v1.5.0 fix the Activity lifecycle issues? We'll verify either way, but it's always good to have more evidence 😄

@daytime-em daytime-em changed the base branch from main to releases/v1.3.0 December 17, 2024 17:12
@daytime-em daytime-em merged commit 7fff193 into muxinc:releases/v1.3.0 Dec 17, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
@EverydayPineapple
Copy link
Contributor Author

@EverydayPineapple Thank you for your contribution! I'll probably be able to get this deployed today.

Just to make sure: Did updating media3 to v1.5.0 by itself fix the Activity lifecycle issues? We'll verify either way, but it's always good to have more evidence 😄

Thanks very much.

Yes, the update to 1.5.0 Media3 fixed my lifecycle issues. I found that because I didn't specifically import the media3 IMA module, I was getting the version Mux referenced. Unfortunately I don't have the time to dig deeper into the actual issue to give you anything more than I was having problems with Activities not being destroyed properly.

Once I override the version, and ensure my app only has 1.5.0 Media3 packages, my tests start passing again.

daytime-em added a commit that referenced this pull request Dec 17, 2024
## Improvements

* chore(dependencies): Update Media3 to 1.5.0 (#72)



Co-authored-by: Ryan McClarnon <[email protected]>
Co-authored-by: GitHub <[email protected]>
@daytime-em
Copy link
Collaborator

@EverydayPineapple Wonderful! We'll close this out then.

This fix should be available in v1.3.0 of Mux Player, which will deploy in the next half hour or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants