Skip to content

Track player dimensions when using the default PlayerView (or SurfaceView or TextureView) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 4, 2025

Conversation

daytime-em
Copy link
Collaborator

@daytime-em daytime-em commented Mar 3, 2025

People who supply their Surface/SurfaceHolder directly, will have to report player size manually

@daytime-em daytime-em requested a review from a team as a code owner March 3, 2025 23:47
Copy link

@walkerfrankenberg walkerfrankenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't know if me approving will allow you to merge) edit: it does! nice

@daytime-em daytime-em merged commit ba8b063 into releases/v1.4.0 Mar 4, 2025
1 check passed
@daytime-em daytime-em deleted the ed/player-res branch March 4, 2025 21:43
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
daytime-em added a commit that referenced this pull request Mar 5, 2025
## Updates

* Add method for updating `CustomerData` (#75)

## Improvements

* Track player dimensions when using the default PlayerView (or SurfaceView or TextureView) (#74)

Co-authored-by: Emily Dixon <[email protected]>
Co-authored-by: GitHub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants