Skip to content

Commit

Permalink
Remove heroku refs.
Browse files Browse the repository at this point in the history
  • Loading branch information
muzam1l committed Dec 17, 2022
1 parent 1ad31f1 commit 7cd4b71
Show file tree
Hide file tree
Showing 4 changed files with 178 additions and 142 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ So just bombard me with pull requests 🥺.

## Deploying

Current setup has front-end deployed on netlify with api calls connected to heroku api server via netlify redirects. It needs VAPID public keys corresponding to server keys for push notifications, and api server address to connect to api. Below is how your environmental variables should like (`.env` file on local and netlify variables when deployed on netlify)
Current setup has front-end deployed on netlify with api calls connected to api server via netlify redirects. It needs VAPID public keys corresponding to server keys for push notifications, and api server address to connect to api. Below is how your environmental variables should like (`.env` file on local and netlify variables when deployed on netlify)

```bash
REACT_APP_PUBLIC_VAPID_KEY=<corresponding public vapid key of vapid keys for push notifications>
REACT_APP_API_SERVER=<server url, like https://myserver.herokuapp.com for production>
REACT_APP_API_SERVER=<server url, like https://myserver.com for production>
```

Note: `REACT_APP_API_SERVER` key is not used in fetch calls, instead used to build netlify redirects and on local, fetch calls are proxied via `proxy` key in `package.json`. So if you plan to deploy it anywhere else, make edits accordingly.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "tclone",
"sideEffects": false,
"version": "2.2.3",
"proxy": "https://tclone-api.herokuapp.com",
"proxy": "https://motionless-long-johns-lion.cyclic.app",
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^1.2.28",
"@fortawesome/free-brands-svg-icons": "^5.13.0",
Expand Down
2 changes: 1 addition & 1 deletion src/comps/PostsList.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function PostsList(props) {
useEffect(useCallback(() => {
if ((status === 'idle' || status === 'done') && !posts.length) {
getPosts()
console.log('fetching on posts load, status:', status)
// console.log('fetching on posts load, status:', status)
}
}, [status, posts, getPosts]), [getPosts])
useBottomScrollListener(useCallback(() => {
Expand Down
Loading

0 comments on commit 7cd4b71

Please sign in to comment.