Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photometric Proposal #183

Merged
merged 31 commits into from
Jun 20, 2024
Merged

Photometric Proposal #183

merged 31 commits into from
Jun 20, 2024

Conversation

moritzstaffel
Copy link
Contributor

No description provided.

@moritzstaffel moritzstaffel changed the base branch from main to next April 17, 2024 11:48
@moritzstaffel
Copy link
Contributor Author

We need to discuss this tomorrow in our meeting

@moritzstaffel
Copy link
Contributor Author

I have updated the definition to the latest discussion we had.

What is missing is:

  • What are we doing about the measurement procedure? Do we want to add some information on how this is done?

gdtf-spec.md Outdated Show resolved Hide resolved
gdtf-spec.md Outdated Show resolved Hide resolved
gdtf-spec.md Show resolved Hide resolved
<SubChannelSet
Beam="Beam1"
LightDistributionFrom="sample_default_file1"
LightDistributionTo="narrow_file1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InterpolateFrom
InterpolateTo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe at to the channel set

gdtf-spec.md Outdated Show resolved Hide resolved
gdtf-spec.md Outdated Show resolved Hide resolved
gdtf-spec.md Show resolved Hide resolved
gdtf-spec.md Outdated
@@ -1386,6 +1388,7 @@ the Beam are specified in [table 41](#user-content-table-41 ).
| BeamType | [Enum](#user-content-attrtype-enum ) | Beam Type; Specified values: "Wash", "Spot", "None", "Rectangle", "PC", "Fresnel", "Glow". Default value "Wash"
| ColorRenderingIndex | [Uint](#user-content-attrtype-uint ) | The CRI according to TM-30 is a quantitative measure of the ability of the light source showing the object color naturally as it does as daylight reference. Size 1 byte. Default value 100. |
| EmitterSpectrum | [Node](#user-content-attrtype-node ) | Optional link to emitter in the physical description; use this to define the white light source of a subtractive color mixing system or the color for the beam when no color mixing is defined. Starting point: Emitter Collect; Default spectrum is a Black-Body with the defined ColorTemperature. |
| LightDistribution | [Resource](#user-content-attrtype-resource ) | Optional. File name without extension and without subfolder containing description of the IES or EULUMDAT file in the subfolder `./light_distribution/`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be inventing new "LightDistribution" terminology, which only describes part of what Photometric Data is and also seems to be used for other purposes. What we want to define is PhotometricData:

  • EULUMDAT is a data file format used for specification of photometric data especially intensity distributions from light sources such as lamps and luminaries.
  • IES Standard File Format for the Electronic Transfer of Photometric Data and Related Information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So rename LightDistribution to PhotometricData? That sounds reasonable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have chosen Photometric now


#### Challenges
- How do we handle multiple beam in one fixture
- Multi LED Strip Light (Challenge is how you measure device)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can control a single pixel, the Photometric Data must be for that pixel. This is done by the data provider (device manufacturer) by taking the overall photometric measurement of the whole device and diving it, to provide data only for that particular pixel.

@moritzstaffel moritzstaffel changed the title Light Distribution Proposal Photometric Proposal May 29, 2024
> We are currently discussing how `Photometric` can be defined as child of a `ChannelFunction`

The rules are the following:
- When a Beam does not have `Photometric`, it will not be affected by any `Photometric` definition in the file (Allow LED rings to have no spectral data while the main light source have this and you still not need to use the `SubChannelSets`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...Allow LED rings to have no photometric data...

@moritzstaffel
Copy link
Contributor Author

  • Put the limitation with the DMX Channels also in the Spec

@moritzstaffel moritzstaffel merged commit f2fc3c5 into next Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants