-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photometric Proposal #183
Photometric Proposal #183
Conversation
We need to discuss this tomorrow in our meeting |
I have updated the definition to the latest discussion we had. What is missing is:
|
<SubChannelSet | ||
Beam="Beam1" | ||
LightDistributionFrom="sample_default_file1" | ||
LightDistributionTo="narrow_file1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InterpolateFrom
InterpolateTo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe at to the channel set
gdtf-spec.md
Outdated
@@ -1386,6 +1388,7 @@ the Beam are specified in [table 41](#user-content-table-41 ). | |||
| BeamType | [Enum](#user-content-attrtype-enum ) | Beam Type; Specified values: "Wash", "Spot", "None", "Rectangle", "PC", "Fresnel", "Glow". Default value "Wash" | |||
| ColorRenderingIndex | [Uint](#user-content-attrtype-uint ) | The CRI according to TM-30 is a quantitative measure of the ability of the light source showing the object color naturally as it does as daylight reference. Size 1 byte. Default value 100. | | |||
| EmitterSpectrum | [Node](#user-content-attrtype-node ) | Optional link to emitter in the physical description; use this to define the white light source of a subtractive color mixing system or the color for the beam when no color mixing is defined. Starting point: Emitter Collect; Default spectrum is a Black-Body with the defined ColorTemperature. | | |||
| LightDistribution | [Resource](#user-content-attrtype-resource ) | Optional. File name without extension and without subfolder containing description of the IES or EULUMDAT file in the subfolder `./light_distribution/`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be inventing new "LightDistribution" terminology, which only describes part of what Photometric Data is and also seems to be used for other purposes. What we want to define is PhotometricData:
- EULUMDAT is a data file format used for specification of photometric data especially intensity distributions from light sources such as lamps and luminaries.
- IES Standard File Format for the Electronic Transfer of Photometric Data and Related Information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So rename LightDistribution to PhotometricData? That sounds reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have chosen Photometric now
|
||
#### Challenges | ||
- How do we handle multiple beam in one fixture | ||
- Multi LED Strip Light (Challenge is how you measure device) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can control a single pixel, the Photometric Data must be for that pixel. This is done by the data provider (device manufacturer) by taking the overall photometric measurement of the whole device and diving it, to provide data only for that particular pixel.
> We are currently discussing how `Photometric` can be defined as child of a `ChannelFunction` | ||
|
||
The rules are the following: | ||
- When a Beam does not have `Photometric`, it will not be affected by any `Photometric` definition in the file (Allow LED rings to have no spectral data while the main light source have this and you still not need to use the `SubChannelSets`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...Allow LED rings to have no photometric data...
|
No description provided.