-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated gdtf xsd to gdtf 1.2 #215
base: main
Are you sure you want to change the base?
Conversation
Thank you @Verschwiegener for the update, this is great. I tested it and it needs some small changes, but it improves the XSD nicely. |
Thanks! I have already done some changes but haven't pushed them yet. What else needs changing so I could implement it? |
Thank you! I have tested it an it seems that all issues it has found were valid, so i don't think i have anything to add here... :) |
@Verschwiegener besides the small proposed changes, are you planning to push in more stuff or can we merge this in as is? |
Sorry I couldn't push the changes yet, I was bussy the last few weeks. I should be able to push them in the coming week |
Another error of the xsd that i found by testing it against gdtf files is that the Wheel Slat name should not be unique (https://github.com/mvrdevelopment/spec/blob/main/gdtf-spec.md#table-12-wheel-slot-attributes) is this desired behavior or should the name be unique? |
Thank you for asking. The slot name should not be unique anymore, we changed it from Name to String and also updated the description. The Next branch is tracking the confirmed updates to the Spec for next release. |
#194