Clarify which XML attribute of a wheel slot is to be used when #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrvanekrobe
force-pushed
the
channel_set_clarification
branch
2 times, most recently
from
1c07f7c
to
c880d59
Compare
gdtf-spec.md
Outdated
| | Gobo(n) | MediaFileName | | ||
| | Prism(n) | Facet | | ||
| | AnimationWheel(n) | MediaFileName | | ||
| | AnimationSystem(n) | AnimationSystem | |
There was a problem hiding this comment.
together with MediaFileName
There was a problem hiding this comment.
Thank you, added
gdtf-spec.md
Outdated
| If the wheel slot has a prism, it has to have one or several children | ||
| called [prism facet](#user-content-prism-facet ). If the wheel slot has an | ||
| If the wheel slot describes a prism, it has to have one or several children | ||
| called [Prism Facet](#user-content-prism-facet ). If the wheel slot describes an | ||
| AnimationWheel, it has to have one child called [Animation |
There was a problem hiding this comment.
I think this should be AnimationSystem
|
|
|
I gave this another look and I think it looks good @petrvanekrobe! |
petrvanekrobe
force-pushed
the
channel_set_clarification
branch
from
d07acc4
to
b12c2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.