Skip to content

Use fillable=False in output_widget #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Use fillable=False in output_widget #405

merged 1 commit into from
Jun 10, 2025

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jun 9, 2025

Without this argument we don't get to see the table in full, see #360

Copy link

github-actions bot commented Jun 9, 2025

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@issue_360

(this requires nodejs, see more at Developing ITables)

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (e6fb0d5) to head (019651d).

Files with missing lines Patch % Lines
apps/shiny/issue_360/app.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   87.85%   87.76%   -0.09%     
==========================================
  Files          49       50       +1     
  Lines        1985     1995      +10     
==========================================
+ Hits         1744     1751       +7     
- Misses        241      244       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts mwouts merged commit e6c55cb into main Jun 10, 2025
15 checks passed
@mwouts mwouts deleted the issue_360 branch June 10, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants