Skip to content

Fix t.state_change is undefined in the Jupyter Widget #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jun 10, 2025

Fixes #407

the error disappears when we use _style instead of style
@mwouts mwouts requested a review from Copilot June 10, 2025 21:00
Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@fix_407

(this requires nodejs, see more at Developing ITables)

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (e6c55cb) to head (a5e6d57).

Files with missing lines Patch % Lines
src/itables/widget/__init__.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   87.76%   87.76%   -0.01%     
==========================================
  Files          50       50              
  Lines        1995     2002       +7     
==========================================
+ Hits         1751     1757       +6     
- Misses        244      245       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mwouts mwouts merged commit ea67756 into main Jun 10, 2025
15 checks passed
@mwouts mwouts deleted the fix_407 branch June 10, 2025 21:12
@mwouts
Copy link
Owner Author

mwouts commented Jun 10, 2025

Hey @manzt, thanks for anywidget, it's a great and easy-to-use framework! Quick question, in this project I was seeing an issue when my style property was passed through a style attribute. I have renamed it to _style and now the issue is gone. Is style a reserved attribute maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address the errors t.state_change is undefined in the Jupyter Widget
2 participants