Add CI/CD workflows for Cloud Functions #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernandezc1
commented
May 2, 2023
There was a problem hiding this comment.
This (fake) test case was purposely done in order for Daniel to show me that the test would successfully run
|
LGTM, although I'm not super familiar with GitHub Actions :) |
Crash-GHaun
approved these changes
May 4, 2023
djperrefort
requested changes
Jul 31, 2023
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| pull_request: |
There was a problem hiding this comment.
You don't need to include the pull_request option if you already have push enabled.
There are cases where both are necessary. E.g.,when triggering on pushes/PRs on specific branches. However, this is not one of those cases.
| CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} | ||
|
|
||
|
|
||
| codacy-coverage-reporter: |
There was a problem hiding this comment.
codacy-coverage-reporter must be indented with two spaces, not four.
djperrefort
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to develop a CI/CD workflow that tests changes to any of the Pitt-Google Broker's microservices when triggered by the following actions:
I appreciate any feedback, as well as any references to documentation of best practices for future improvements.