Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #228 #229

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix #228 #229

merged 1 commit into from
Jun 13, 2024

Conversation

troyraen
Copy link
Collaborator

@troyraen troyraen commented Jun 1, 2024

Fixes #228

Fallback to an empty dictionary instead of None when the alert contains no previous detections.

@troyraen troyraen marked this pull request as ready for review June 13, 2024 00:44
@troyraen
Copy link
Collaborator Author

@hernandezc1 do you want to push this change into production when you re-deploy the Cloud Functions with python 3.12?
If so:

  1. I ask that you do a quick test deployment first to make sure everything works together (I see no reason why it shouldn't, but haven't tested it myself).
  2. Feel free to approve and merge this PR without waiting for anything else from me.

If not, feel free to ignore it for now.

@hernandezc1 hernandezc1 self-requested a review June 13, 2024 19:14
@hernandezc1
Copy link
Collaborator

hernandezc1 commented Jun 13, 2024

  1. I ask that you do a quick test deployment first to make sure everything works together (I see no reason why it shouldn't, but haven't tested it myself).

Successfully tested changes. No errors

@hernandezc1 hernandezc1 merged commit 03c6fed into develop Jun 13, 2024
4 checks passed
@hernandezc1 hernandezc1 deleted the u/raen/bugfix/no_prv_srcs branch June 13, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: TypeError in Lite module
2 participants