Update ps_to_storage source code #263
Open
+46
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernandezc1
changed the title
troyraen
reviewed
Mar 11, 2025
|
@troyraen things look a bit nicer now. Still needs to be tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code in
main.pyand uses version 0.3.12 of the pittgoogle-client.This code has been tested. Notably, the following error message was seen:
"The request was aborted because there was no available instance. Additional troubleshooting documentation can be found at: https://cloud.google.com/run/docs/troubleshooting#abort-request"
Context:
The error message count was 31. There were ~13,500 alerts processed.
Since the default number of container instances is zero, I think it's reasonable to assume that the sudden increase in traffic and a long cold start time are the source of the issue. Worth discussing if it's worthwhile to change the minimum number of instances.