Update pr to main #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tooltip help regarding the playback rate change buttons stated that those raise/lower pitch. If keylock is disabled, this is true, though incomplete, since the buttons also affect playback speed. If keylock is enabled, this is false, since pitch is left unchanged, and only playback speed changes. This commit replaces the tooltip text about pitch change with text about playback speed. It also copies the clarification: "(affects both the tempo and the pitch). If keylock is enabled, only the tempo is affected." over from the Speed Control fader tooltip, to prevent further confusion.
…ls) so we can also add tracks based on ids directly
… track is already loaded
…sary intermediate slot, comments and debugging output, formatting)
…rd for the case this mime type is used elsewhere)
avoids hitting DEBUG_ASSERT when removing tracks from a locked crate
fixes around cratetablemodel, remove tracks + don't allow pasting tracks into locked playlists/crates or History
Co-authored-by: Daniel Schürmann <[email protected]>
Co-authored-by: ronso0 <[email protected]>
shortkeys for track list management
Improve `rate_up/down` tooltips, pitch vs. speed
Add CI runner that allows cleaning up the download server
CMakeLists: Fix deduplication trap with `--preload-file`
src/library: sort files into sub-directories
Track menu: rephrase "Reset" to "Clear"
…ForKeyboardTrackpad Removed old examples HID keyboard and HID trackpad
only for those BaseTrackPlayer created the ControlPushButtons
[PreviewDeckN],LoadSelectedTrackAndPlay toggles play/pause if the track is already loaded
Co-authored-by: JoergAtGithub <[email protected]>
(fix) Track widgets: set `show_track_menu` only for main decks
Update Changelog for 2.5-alpha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.