Convert the manual-test workflow to allow specifying which runner OS to use
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, the `manual-test` workflow accepts user input as to what runner OS or Docker image to run on. It is more useful this way, too, as I never encountered a situation where I would want to run this Action on multiple runners, having to log in concurrently into multiple tmate sessions, and I doubt that anyone else has encountered that situation, either. Signed-off-by: Johannes Schindelin <[email protected]>
As I had suggested in mxschmitt#224 (comment), it would be good to have some sort of automation to update the ever-changing list of runner pools that are supported by GitHub. Signed-off-by: Johannes Schindelin <[email protected]>
Brought to you by the new `update-manual-test.js` script. Signed-off-by: Johannes Schindelin <[email protected]>
For a little more than two weeks, as of time of writing, there are GitHub-hosted Windows/ARM64 runners (at long last!), announced here: https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/ These are not yet listed in the `runner-images` README, therefore we want to add them manually. Signed-off-by: Johannes Schindelin <[email protected]>
The Windows/ARM64 runners that are currently in public preview do not have MSYS2 installed by default, so let's do that. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I realized in #224 (comment), the
manual-testworkflow, which is currently set up as a matrix job that runs one job for every available runner OS (and then a couple more Docker containers), is not very useful as-is. Nobody logs into a dozen tmate sessions concurrently to do anything reasonable.What is typically needed is a single runner OS, or Docker container.
So let's switch this to a workflow where the user specified via
workflow_dispatchinput what exactly they want to run.While at it, add a script to update the list of available runner images by scraping the official
runner-imagesREADME. I considered adding a scheduled GitHub workflow to update this on a regular basis, but unfortunatelygit pushis not permitted with the regular ActionsGITHUB_TOKENwhen it updates anything inside.github/workflows/. So this will have to be done manually.As a doozy, this PR also adds support for running
manual-teston the shiny new public preview of the GitHub-hosted Windows/ARM64 runners (where it is a bit tricky to runaction-tmatebecause the MSYS2 installation is simply not where it is expected, and evenmsys2/setup-msys2expects it to be there and needs to becajoledconvinced to install it).