Using Eloquent for #5. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return array | ||
| */ | ||
| function getAllForParsing(); |
There was a problem hiding this comment.
Still working on cleaning it all up.
|
There's a small standards issue and this repo could do with some unit tests. |
|
I'll look into it and fix it tomorrow before merging. The unit tests are part of the larger plan: #4 Right now, there's a single parser class doing everything. This is pretty untestable, so I'm waiting until I've done my refactoring and split it out a bit |
|
Fair does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to using Eloquent and putting all repositories under a single namespace, making things slightly cleaner.