Convert Example Apps to TypeScript and Add Expo Support#913
Open
hellostu wants to merge 13 commits intomybigday:masterfrom
Open
Convert Example Apps to TypeScript and Add Expo Support#913hellostu wants to merge 13 commits intomybigday:masterfrom
hellostu wants to merge 13 commits intomybigday:masterfrom
Conversation
hellostu
changed the title
hellostu
force-pushed
the
expo-example
branch
from
2d57a02 to
5189711
Compare
hellostu
changed the title
hellostu
force-pushed
the
expo-example
branch
2 times, most recently
from
79b7a27 to
c0193dd
Compare
hellostu
force-pushed
the
expo-example
branch
4 times, most recently
from
f70369e to
85e9952
Compare
hellostu
force-pushed
the
expo-example
branch
from
85e9952 to
1cb5a12
Compare
hellostu
force-pushed
the
expo-example
branch
from
3932b3f to
6534615
Compare
hellostu
force-pushed
the
expo-example
branch
from
6534615 to
ab4dc7c
Compare
hellostu
force-pushed
the
expo-example
branch
from
5cbb82b to
60266d1
Compare
hellostu
force-pushed
the
expo-example
branch
from
60266d1 to
9d4abfe
Compare
hellostu
force-pushed
the
expo-example
branch
from
9df8a13 to
a162b60
Compare
hellostu
force-pushed
the
expo-example
branch
from
2131108 to
482ad81
Compare
hellostu
changed the title
jhen0409
reviewed
Oct 19, 2024
| @@ -1 +1,2 @@ | |||
| node_modules No newline at end of file | |||
| node_modules | |||
| apps No newline at end of file | |||
Member
There was a problem hiding this comment.
I think we should keep eslint for apps.
We can follow our projects that already used TypeScript: https://github.com/mybigday/llama.rn/blob/f35545b92241d8cc9ee2b22b5ca4c02b395db9bb/package.json#L127-L203
Then the package also needs to be rewritten in TypeScript since it uses Flow, and it may need a build script.
Contributor
Author
There was a problem hiding this comment.
Sorry for delayed reply. This was so the PR didn't get huge. I was going to do Typescript rewrite in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following updates to the react-native-external-display library:
Conversion of Example Apps to TypeScript:
The example apps have been fully converted from JavaScript to TypeScript, providing better type safety and improving the overall developer experience when working with the examples.
Added Support for Expo:
The example apps have been updated to run within the Expo environment, making it easier for developers using Expo to integrate and test the external display functionality. This PR deletes all the native Objective-C and Java code, allowing Expo to auto-generate the required native code. The iPad example applies its changes via a custom Expo plugin, streamlining the integration with Expo's ecosystem.
Migration to Yarn 4.5:
The project now uses Yarn 4.5 to manage dependencies, bringing improvements in dependency resolution, performance, and workspace handling.
GitHub Actions Update for Expo:
This PR also includes updates to the GitHub Actions configuration. The workflow has been updated to use the new Expo versions of the example apps for continuous integration (CI). These changes ensure that the build and testing pipelines reflect the new Expo-based project setup, including the removal of native code and the auto-generation of necessary build files via Expo.
Rationale:
These changes aim to: