fix: typeof instead of instanceof to check for object #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had an issue with some of the toolbar button (bold/italic) that were not working.
I think it had to do with the way I loadData(), but could not figure out what's wrong exactly.
Here's the issue from devtool (it is a style.font) :
This would make the
helper.equals
returns truthy instead of falsy which skip the creation of a new style (thus reuse an existing one).