Skip to content

Conversation

@martinslice
Copy link

@martinslice martinslice commented Jun 5, 2025

  1. Added shop_id into the acts_as_account_postings schema
  2. shop_id is populated when creating posting in the acts_as_account_postings table

Meriton Chutra and others added 2 commits August 6, 2020 14:05
Copy link

@mockra mockra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇🏻‍♂️

@angelov
Copy link

angelov commented Jun 9, 2025

We should either merge this to the mchutra/deadlock-fixes branch instead of master (as admin is using that one when fetching this gem), or have that branch as a base for these changes and then update admin.

gem 'acts_as_account', github: 'mypizza/acts_as_account', branch: 'mchutra/deadlock-fixes'

@martinslice martinslice changed the base branch from master to mchutra/deadlock-fixes June 9, 2025 10:44
@martinslice
Copy link
Author

@angelov Base branch updated. Now the changes are pointed to mchutra/deadlock-fixes.

Copy link

@DementorH DementorH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, make sure to test it thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants