Skip to content

refactor!: use quic-rpc 0.15 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 6, 2024
Merged

refactor!: use quic-rpc 0.15 #6

merged 8 commits into from
Nov 6, 2024

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Nov 5, 2024

Description

Use quic-rpc v0.15.0 and adapt API. Most notably we can get rid of an entire type parameter.

Breaking Changes

Gossip::handle_rpc_request type parameters adapted to v0.15
rpc::client::Client type parameters adapted to v0.15
rpc::client::Client::new adapted to v0.15

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Copy link

github-actions bot commented Nov 5, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/6/docs/iroh_gossip/

Last updated: 2024-11-06T09:44:34Z

@rklaehn rklaehn changed the title Try out new quicrpc refactor: use quic-rpc 0.15 Nov 6, 2024
@rklaehn rklaehn marked this pull request as ready for review November 6, 2024 09:48
@dignifiedquire dignifiedquire changed the title refactor: use quic-rpc 0.15 refactor!: use quic-rpc 0.15 Nov 6, 2024
@rklaehn rklaehn merged commit 3d6659d into main Nov 6, 2024
29 of 30 checks passed
@rklaehn rklaehn deleted the try-out-new-quicrpc branch November 6, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants