refactor!: flatten event enum #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simulation reportLast updated: 2025-06-07T12:20:17Z |
Frando
force-pushed
the
Frando/flatten-events
branch
from
9aa773a to
3482a0d
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/73/docs/iroh_gossip/ Last updated: 2025-06-07T12:20:41Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #72
This flattens the
Eventenum to contain the variants fromGossipEventdirectly. Makes code that matches on the events much easier to read IMO.Breaking Changes
iroh_gossip::api::GossipEventis removed. Its variants are now directly available oniroh_gossip::api::Eventiroh_gossip::api::Eventnow contains the variants fromGossipEventin addition toLagged. TheGossipvariant is removed.Notes & open questions
Change checklist