Skip to content

refactor!: cleanup and improve hyparview protocol #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: Frando/irpc
Choose a base branch
from

Conversation

Frando
Copy link
Member

@Frando Frando commented Jun 9, 2025

Description

Wire-breaking change

Based on #67

This does a couple of wire-breaking cleanups to the hyparview protocol. Easiest is to review commit-by-commit.

TODO Detail changes

Breaking Changes

  • Added JoinFailed variant to proto::hyparview::Event and api::Event

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Copy link

github-actions bot commented Jun 9, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/76/docs/iroh_gossip/

Last updated: 2025-06-09T11:54:54Z

Copy link

github-actions bot commented Jun 9, 2025

Simulation report
GossipAll-n100-r5 with 4 seeds
        RMR    LDH  missed  duration 
 mean  1.25   9.40    0.00     639ms 
  max  1.27  10.00    0.00     696ms 
  min  1.23   8.00    0.00     494ms 

GossipAll-n20-r30 with 4 seeds
        RMR   LDH  missed  duration 
 mean  1.73  3.80    0.00     373ms 
  max  1.94  5.00    0.00     411ms 
  min  1.55  3.00    0.00     172ms 

GossipMulti-n100-r30 with 4 seeds
        RMR    LDH  missed  duration 
 mean  0.53   9.73    0.00     286ms 
  max  1.78  12.00    0.00     362ms 
  min  0.10   5.00    0.00     150ms 

GossipMulti-n1000-r30 with 4 seeds
        RMR    LDH  missed  duration 
 mean  0.49  20.03    0.00     549ms 
  max  2.70  25.00    0.00     649ms 
  min  0.16  12.00    0.00     291ms 

GossipMulti-n20-r30 with 4 seeds
        RMR   LDH  missed  duration 
 mean  0.21  4.63    0.00     110ms 
  max  2.33  6.00    0.00     201ms 
  min  0.06  2.00    0.00      65ms 

GossipSingle-n100-r30 with 4 seeds
        RMR   LDH  missed  duration 
 mean  0.11  5.00    0.00     150ms 
  max  1.58  5.00    0.00     150ms 
  min  0.01  5.00    0.00     150ms 

GossipSingle-n1000-r30 with 4 seeds
        RMR    LDH  missed  duration 
 mean  0.10  12.00    0.00     291ms 
  max  2.70  12.00    0.00     291ms 
  min  0.00  12.00    0.00     291ms 

GossipSingle-n20-r30 with 4 seeds
        RMR   LDH  missed  duration 
 mean  0.17  2.00    0.00      65ms 
  max  2.39  2.00    0.00      65ms 
  min  0.06  2.00    0.00      65ms 

comparing GossipAll-n100-r5
               RMR          LDH       missed     duration 
 mean      +23.78%       -6.00%       +0.00%      -10.56% 
 max       +24.70%       -9.09%       +0.00%      -11.67% 
 min       +22.09%      -11.11%       +0.00%       +0.78% 
comparing GossipAll-n20-r30
               RMR          LDH       missed     duration 
 mean      +25.99%      -24.50%       +0.00%       -5.21% 
 max       +32.85%      -28.57%       +0.00%       -7.27% 
 min       +38.59%       +0.00%       +0.00%      -26.04% 
comparing GossipMulti-n100-r30
               RMR          LDH       missed     duration 
 mean      +56.71%       -4.26%       +0.00%       -3.95% 
 max       +18.37%      -14.29%       +0.00%      -11.51% 
 min       +42.86%       +0.00%       +0.00%       +2.03% 
comparing GossipMulti-n1000-r30
               RMR          LDH       missed     duration 
 mean      +10.59%       -1.96%       +0.00%       -5.86% 
 max       +31.45%       -3.85%       +0.00%       -9.61% 
 min      +321.05%       +0.00%       +0.00%       -8.59% 
comparing GossipMulti-n20-r30
               RMR          LDH       missed     duration 
 mean      -20.55%      +16.81%       +0.00%      -24.22% 
 max       +44.83%       +0.00%       +0.00%      -23.87% 
 min        +0.00%       +0.00%       +0.00%      -21.57% 
comparing GossipSingle-n100-r30
               RMR          LDH       missed     duration 
 mean      +34.84%       +0.00%       +0.00%       +2.03% 
 max        +5.44%       +0.00%       +0.00%       +2.03% 
 min        +0.00%       +0.00%       +0.00%       +2.03% 
comparing GossipSingle-n1000-r30
               RMR          LDH       missed     duration 
 mean      +42.03%       +0.00%       +0.00%       -8.59% 
 max       +31.45%       +0.00%       +0.00%       -8.59% 
 min      +200.01%       +0.00%       +0.00%       -8.59% 
comparing GossipSingle-n20-r30
               RMR          LDH       missed     duration 
 mean      +19.74%      -33.33%       +0.00%      -21.57% 
 max       +65.38%      -33.33%       +0.00%      -21.57% 
 min        +0.00%      -33.33%       +0.00%      -21.57% 

Last updated: 2025-06-09T11:56:04Z

@Frando Frando force-pushed the Frando/hyparview-refactor branch from 4d5f13c to 7608bbc Compare June 9, 2025 11:53
@n0bot n0bot bot added this to iroh Jun 9, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant