feat: add cli #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/9/docs/iroh_gossip/ Last updated: 2024-11-18T13:24:00Z |
the binary doesn't have a name yet, might not be iroh
dignifiedquire
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add gossip cli from iroh
Breaking Changes
None, this just adds stuff under the "cli" feature flag that is off by default.
Notes & open questions
Note: the API under the "cli" feature flag is tested, but it wasn't tested in iroh either. Given that it is a non-default flag I think we can still merge it. The alternative is throwing away all cli stuff entirey.
Change checklist