feat(editor): Add follow up question nps #17459

nikhilkuria · 2025-07-18T16:15:40Z

Summary

https://www.loom.com/share/fbcfc870b45e4c67a83eedaf82936dce

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3808/feature-add-follow-up-question-to-nps

Review / Merge checklist

PR title and summary are descriptive. (conventions)
Docs updated or follow-up ticket created.
Tests included.
PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

bundlemon · 2025-07-18T16:22:51Z

BundleMon

Unchanged files (2)

Status	Path	Size	Limits
✅	WASM Dependencies _{tree-sitter-bash.wasm}	181.26KB	-
✅	WASM Dependencies _{tree-sitter.wasm}	74.47KB	-

No change in files bundle size

Groups updated (2)

Status	Path	Size	Limits
✅	*/.js	5.3MB (+166.09KB +3.16%)	-
✅	*/.css	184.62KB (+5.57KB +3.11%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

currents-bot · 2025-07-18T16:23:08Z

✅

E2E Tests: n8n tests passed after 4m 12.8s

🟢 521 · 🔴 0 · ⚪️ 1

View Run Details

Run Details

Project: n8n
Groups: 3
Framework: Playwright
Run Status: Passed
Commit: 1df2e15
Spec files: 110
Overall tests: 522
Duration: 4m 12.8s
Parallelization: 3

Groups

GroupId	Results	Spec Files Progress
mode:standard - Parallel	🟢 9 · 🔴 0 · ⚪️ 1	3 / 3
mode:standard - Sequential	🟢 4 · 🔴 0 · ⚪️ 0	2 / 2
No name	🟢 508 · 🔴 0 · ⚪️ 0	105 / 105

This message was posted automatically by currents.dev | Integration Settings

cypress · 2025-07-18T16:27:44Z

n8n Run #12350

Run Properties: Failed #12350 • e18ffe809c: 🌳 master 🤖 PR User 🗃️ e2e/*

Project	`n8n`
Branch Review	`master`
Run status	`Failed #12350`
Run duration	`04m 19s`
Commit	`e18ffe809c: 🌳 master 🤖 PR User 🗃️ e2e/*`
Committer	`Nikhil Kuriakose`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`0`
Pending	`2`
Skipped	`0`
Passing	`280`
View all changes introduced in this branch ↗︎

Tests for review

6-code-node.cy.ts • 1 failed test

View Output Video

Test		Artifacts
Code node > Code editor > should show lint errors in `runOnceForEachItem` mode		`Test Replay` `Screenshots` `Video`

48-subworkflow-inputs.cy.ts • 0 failed tests

View Output

Test		Artifacts

41-editors.cy.ts • 0 failed tests

View Output

Test		Artifacts

11-inline-expression-editor.cy.ts • 0 failed tests

View Output

Test		Artifacts

14-mapping.cy.ts • 0 failed tests

View Output

Test		Artifacts

The first 5 failed specs are shown, see all 58 specs in Cypress Cloud.

codecov · 2025-07-18T16:29:08Z

Codecov Report

❌ Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...es/frontend/editor-ui/src/components/NpsSurvey.vue	0.00%	38 Missing ⚠️

📢 Thoughts on this report? Let us know!

cubic-dev-ai

cubic reviewed 4 files and found no issues. Review PR in cubic.dev.

CharlieKolb

🚀

CharlieKolb · 2025-07-21T06:42:17Z

packages/frontend/editor-ui/src/components/NpsSurvey.vue

 	if (form?.value?.value !== '') {
-		if (Number(form.value) > 7) {


Nice catch!

currents-bot · 2025-07-25T14:22:46Z

❌

E2E Tests: n8n tests failed after 1h 51m 34.8s

🟢 247 · 🔴 1 · ⚪️ 0

View Run Details

Run Details

Project: n8n
Groups: 1
Framework: Currents
Run Status: Failed
Commit: e6c4b24
Spec files: 31
Overall tests: 248
Duration: 1h 51m 34.8s
Parallelization: 1

Failed Spec Files

Spec File	Failures
NpsSurvey	1

This message was posted automatically by currents.dev | Integration Settings

CharlieKolb

🚀

janober · 2025-07-28T15:13:28Z

Got released with [email protected]

nikhilkuria added 3 commits July 18, 2025 14:43

feat(ado-3808) initial version of new feedback question

37014b5

feat(ado-3808) edit on styles and e2e tests

ccfa7d4

feat(ado-3808) feedback is sent if npn modal is close prematurely

e7f1941

nikhilkuria changed the title ~~Feat ado 3808 add follow up question nps~~ feat(editor): Add follow up question nps Jul 18, 2025

n8n-assistant bot added the n8n team Authored by the n8n team label Jul 18, 2025

nikhilkuria requested review from a team, dariacodes and CharlieKolb and removed request for a team and dariacodes July 18, 2025 16:31

nikhilkuria marked this pull request as ready for review July 18, 2025 16:31

cubic-dev-ai bot reviewed Jul 18, 2025

View reviewed changes

CharlieKolb previously approved these changes Jul 21, 2025

View reviewed changes

feat(ado-3808)-design changes

7637f37

nikhilkuria dismissed CharlieKolb’s stale review via 7637f37 July 22, 2025 10:02

CharlieKolb previously approved these changes Jul 22, 2025

View reviewed changes

feat(ado-3808): removing email question and style changes

4767853

nikhilkuria dismissed CharlieKolb’s stale review via 4767853 July 25, 2025 12:17

feat(ado-3808): remove email from e2e tests

e6c4b24

nikhilkuria added 3 commits July 25, 2025 16:31

fix(ado-3808): use new test id for button

cd6e67c

fix(ado-3808): add identifier for feedback button

69de49c

feat(ado-3808): fix typo in component name

1df2e15

CharlieKolb approved these changes Jul 25, 2025

View reviewed changes

nikhilkuria merged commit e18ffe8 into master Jul 25, 2025
54 checks passed

nikhilkuria deleted the feat-ADO-3808-add-follow-up-question-nps branch July 25, 2025 15:26

This was referenced Jul 28, 2025

🚀 Release 1.105.0 #17745

Closed

🚀 Release 1.105.0 #17752

Merged

janober added the Released label Jul 28, 2025

cstuncsik pushed a commit that referenced this pull request Aug 1, 2025

feat(editor): Add follow up question nps (#17459)

51f5a57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(editor): Add follow up question nps #17459

feat(editor): Add follow up question nps #17459

Uh oh!

nikhilkuria commented Jul 18, 2025

Uh oh!

bundlemon bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

currents-bot bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

cypress bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

CharlieKolb left a comment

Uh oh!

CharlieKolb Jul 21, 2025

Uh oh!

currents-bot bot commented Jul 25, 2025

Uh oh!

CharlieKolb left a comment

Uh oh!

Uh oh!

janober commented Jul 28, 2025

Uh oh!

Uh oh!

		if (form?.value?.value !== '') {
		if (Number(form.value) > 7) {

feat(editor): Add follow up question nps #17459

feat(editor): Add follow up question nps #17459

Uh oh!

Conversation

nikhilkuria commented Jul 18, 2025

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

Uh oh!

bundlemon bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BundleMon

Uh oh!

currents-bot bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cypress bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

n8n Run #12350

Tests for review

Uh oh!

codecov bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

CharlieKolb left a comment

Choose a reason for hiding this comment

Uh oh!

CharlieKolb Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

currents-bot bot commented Jul 25, 2025

Uh oh!

CharlieKolb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

janober commented Jul 28, 2025

Uh oh!

Uh oh!

bundlemon bot commented Jul 18, 2025 •

edited

Loading

currents-bot bot commented Jul 18, 2025 •

edited

Loading

cypress bot commented Jul 18, 2025 •

edited

Loading

codecov bot commented Jul 18, 2025 •

edited

Loading