-
Notifications
You must be signed in to change notification settings - Fork 38.8k
fix: Fix issue with icon themes not loading for preview nodes #17869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix issue with icon themes not loading for preview nodes #17869
Conversation
…k-and-light-icons-rendering-for-cnoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic analysis
No issues found across 2 files. Review in cubic
BundleMonFiles added (2)
Total files change +255.73KB Groups added (2)
Final result: ✅ View report in BundleMon website ➡️ |
…get-dark-and-light-icons-rendering-for-cnoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
E2E Tests: n8n tests passed after 4m 39s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
Co-authored-by: Michael Kret <[email protected]>
Co-authored-by: Michael Kret <[email protected]>
Got released with |
Summary
INodeTypeDescription
supportsiconUrl
which works for local paths but for community node previews we were always expecting just one url, This PR adds support for the themes while also keeping the option to have a single iconUrl.For testing set
ENVIRONMENT=staging
to use the staging Strapi instance then search forBinalyze
orAir
Light Mode

Dark Mode

This change will also require a workflow update for publishing community nodes to make sure we set the below
The current setting below does still work so we can merge and release before we make any changes.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3396/get-dark-and-light-icons-rendering-for-cnoc
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)