Skip to content

fix: Fix issue with icon themes not loading for preview nodes #17869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jul 31, 2025

Summary

INodeTypeDescription supports iconUrl which works for local paths but for community node previews we were always expecting just one url, This PR adds support for the themes while also keeping the option to have a single iconUrl.

For testing set ENVIRONMENT=staging to use the staging Strapi instance then search for Binalyze or Air

Light Mode
image

image

Dark Mode
image

image

This change will also require a workflow update for publishing community nodes to make sure we set the below

iconUrl: {
  light: 'xx',
  dark: 'yy'
}

The current setting below does still work so we can merge and release before we make any changes.

iconUrl: 'xx'

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-3396/get-dark-and-light-icons-rendering-for-cnoc

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 2 files. Review in cubic

@Joffcom Joffcom requested a review from michael-radency July 31, 2025 15:18
Copy link

bundlemon bot commented Jul 31, 2025

BundleMon

Files added (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
+181.26KB -
WASM Dependencies
tree-sitter.wasm
+74.47KB -

Total files change +255.73KB

Groups added (2)
Status Path Size Limits
**/*.js
+5.34MB -
**/*.css
+187.85KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jul 31, 2025
…get-dark-and-light-icons-rendering-for-cnoc
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

currents-bot bot commented Aug 1, 2025

E2E Tests: n8n tests passed after 4m 39s

🟢 508 · 🔴 0 · ⚪️ 0

View Run Details

Run Details

  • Project: n8n

  • Groups: 1

  • Framework: Currents

  • Run Status: Passed

  • Commit: 0035f05

  • Spec files: 105

  • Overall tests: 508

  • Duration: 4m 39s

  • Parallelization: 1


This message was posted automatically by currents.dev | Integration Settings

@Joffcom Joffcom merged commit 6d1f2cb into master Aug 1, 2025
35 checks passed
@Joffcom Joffcom deleted the node-3396-get-dark-and-light-icons-rendering-for-cnoc branch August 1, 2025 13:49
cstuncsik pushed a commit that referenced this pull request Aug 1, 2025
despairblue pushed a commit that referenced this pull request Aug 4, 2025
@github-actions github-actions bot mentioned this pull request Aug 4, 2025
@janober
Copy link
Member

janober commented Aug 4, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants