fix(GraphQL Node): Refresh OAuth2 token when it expires

[RomanDavydchuk]

Summary

Fix an issue where the OAuth2 access token is not refreshed in the GraphQL node when receiving a 401

Dummy NodeJS server that can be used to test the refresh logic:

const http = require("http");
const url = require("url");
const querystring = require("querystring");

let reject = true;

const server = http.createServer((req, res) => {
  const parsedUrl = url.parse(req.url);
  const pathname = parsedUrl.pathname;
  const query = querystring.parse(parsedUrl.query);

  if (pathname === "/authorize") {
    console.log("Endpoint /authorize hit");
    const code = "dummy_code";
    const redirectUri = query.redirect_uri;
    const redirectWithCode = `${redirectUri}?code=${code}&state=${query.state || ""}`;
    res.writeHead(302, { Location: redirectWithCode });
    res.end();
  } else if (pathname === "/token" && req.method === "POST") {
    console.log("Endpoint /token hit");
    let body = "";
    req.on("data", (chunk) => (body += chunk));
    req.on("end", () => {
      const parsedBody = querystring.parse(body);
      if (parsedBody.grant_type === "refresh_token") {
        console.log("Refreshing the token");
      } else {
        console.log("Returning the initial token");
      }

      res.writeHead(200, { "Content-Type": "application/json" });
      res.end(
        JSON.stringify({
          access_token: "dummy_access_token",
          refresh_token: "dummy_refresh_token",
          token_type: "Bearer",
          expires_in: 3600,
        }),
      );
    });
  } else {
    console.log(`Endpoint ${pathname} hit`);
    if (reject) {
      console.log("Responding with 401");
      res.writeHead(401, { "content-type": "application/json" });
      res.end(JSON.stringify({ error: "unauthorized" }));
    } else {
      console.log("Responding with 200");
      res.writeHead(200, { "content-type": "application/json" });
      res.end(JSON.stringify({ foo: "bar" }));
    }

    reject = !reject;
  }
});

server.listen(3000, () => {
  console.log(`Running on http://localhost:3000`);
});

Add an OAuth2 credential with Authorization URL: http://localhost:3000/authorize and Token URL: http://localhost:3000/token (client ID and secret can be whatever) to test with this code. Before the fix the GraphQL would not try to refresh the token after getting a 401, after the fix - it does

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1766/graphql-node-not-refreshing-oauth2-token-in-graphql-node
https://community.n8n.io/t/n8n-not-refreshing-oauth-token-in-graphql-node/54363/2

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[cubic-dev-ai]

cubic analysis

No issues found across 3 files. Review in cubic

[ShireenMissi]

I tested locally using the instructions from the PR description and it works as expected ✅

[currents-bot]

✅

E2E Tests: n8n tests passed after 3m 57.6s

🟢 500 · 🔴 0 · ⚪️ 0

View Run Details

Run Details

• Project: n8n

• Groups: 1

• Framework: Currents

• Run Status: Passed

• Commit: 2f7cb9f

• Spec files: 105

• Overall tests: 500

• Duration: 3m 57.6s

• Parallelization: 1

---

This message was posted automatically by currents.dev | Integration Settings