feat(FTP Node): Add support for concurrent reads when using SFTP #17896
+118
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
1 issue found across 2 files • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
n8n-assistant
bot
added
n8n team
…tp-download-performance-in-ftp-node
…slow-sftp-download-performance-in-ftp-node
|
E2E Tests: n8n tests passed after 5m 12.1s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
Joffcom
deleted the
node-2915-slow-sftp-download-performance-in-ftp-node
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new option to the FTP Node to support concurrent reads when using SFTP, This results in a 100MB download completing in ~19 seconds instead of 2+ minutes. This option is not enabled by default as some SFTP server configurations may not fully allow concurrent reads.
This PR also enables compression and bumps the package version.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2915/slow-sftp-download-performance-in-ftp-node
https://support.n8n.io/#ticket/zoom/18223
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)