ci: Playwright project organization #17905
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the Playwright test project structure to provide clearer organization and better command interfaces for running different test types. The changes standardize test commands using a hierarchical naming scheme (test:ui, test:performance, test:workflows) and consolidate project configuration into dedicated modules.
- Refactors project configuration from inline definitions to an external
playwright-projects.tsmodule - Reorganizes test directory structure and fixes import paths for better organization
- Updates npm scripts and CI workflows to use new standardized command names
Reviewed Changes
Copilot reviewed 9 out of 364 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| playwright.config.ts | Simplifies configuration by moving project definitions to external module |
| playwright-projects.ts | New module containing all project configurations with improved organization |
| package.json | Updates npm scripts to use new hierarchical naming scheme |
| workflow-tests.spec.ts | Fixes paths and adds utility import for better path resolution |
| setup-workflow-tests.ts | Updates asset paths and adds utility import for path resolution |
| multimain.spec.ts | Fixes import path to match new directory structure |
| README.md | Updates documentation to reflect new command structure |
| root package.json | Updates references to use new command names |
| CI workflow | Updates test commands to match new naming scheme |
Comments suppressed due to low confidence (2)
packages/testing/playwright/package.json:24
- Playwright version 1.54.2 may not exist. The latest known version as of January 2025 was around 1.48.x. Please verify this version exists before merging.
"@playwright/test": "1.54.2",
packages/testing/playwright/package.json:26
- eslint-plugin-playwright version 2.2.2 may not exist. The latest known version as of January 2025 was around 1.6.x. Please verify this version exists before merging.
"eslint-plugin-playwright": "2.2.2",
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
4 issues found across 17 files • Review in cubic
Note: This PR contains a large number of files. cubic only reviews up to 150 files per PR, so some files may not have been reviewed.
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/testing/playwright/tests/cli-workflows/workflow-tests.spec.ts
Outdated
Show resolved
Hide resolved
shortstacked
force-pushed
the
playwright-project-cleanup
branch
from
72789e7 to
c4267ec
Compare
shortstacked
force-pushed
the
playwright-project-cleanup
branch
2 times, most recently
from
8cfd0a0 to
23fabda
Compare
shortstacked
force-pushed
the
playwright-project-cleanup
branch
from
23fabda to
7f55fc0
Compare
shortstacked
force-pushed
the
playwright-project-cleanup
branch
from
263a851 to
6348a43
Compare
| @@ -20,6 +20,22 @@ function findProjectRoot(marker: string): string { | |||
| return dir; | |||
| } | |||
|
|
|||
| /** | |||
| * Finds a folder root by searching upwards for a marker folder named 'packages'. | |||
There was a problem hiding this comment.
I think the marker is not passed as an argument?
fix: more tests test: Migrating 1-workflows to Playwright fix: PR feedback fix: Updating based on PR feedback Added extra documentation for setup/running tests. fix: testing migration auto fix: Run tag tests sequential to avoid DB issues feat: Add Playwright project improvements
shortstacked
force-pushed
the
playwright-project-cleanup
branch
from
6348a43 to
581a018
Compare
|
E2E Tests: n8n tests passed after 3m 56.3s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
|
E2E Tests: n8n tests passed after 3m 6s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
Summary
Cleans up and provides a better structure for the Playwright test project.
Allows clearer commands for running the different test types available e.g
UI: pnpm test:ui
Perf: pnpm test:perf
Better organization of test folder structure to make it easier to find/add tests.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)