fix(core): Prevent re-entry during workflow activation #17965
Merged
+42
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files. Review in cubic
n8n-assistant
bot
added
core
|
E2E Tests: n8n tests passed after 4m 7.4s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
ivov
deleted the
cat-1069-bug-enterprise-client-bakkt-schedule-trigger-node-firing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have a guarantee that an instance is a leader or a follower by the time we reach workflow activation, but there is a race condition where workflow activation is triggered in reaction to a leadership acquisition while regular workflow activation on bootup is ongoing.
Workflow activation logic ideally should be atomic, possibly by queuing activations, but that is a larger refactor that will need to be its own dedicated effort. For now this PR prevents re-entry to protect against the race condition.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-1069
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)