Skip to content

fix(core): Handle null workflow settings in toSaveSettings #17972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

burivuhster
Copy link
Contributor

@burivuhster burivuhster commented Aug 4, 2025

Summary

  • Fixed a bug where null workflow settings from the database would cause a 'Cannot read properties of null' error
  • Added nullish coalescing operator to handle null values gracefully

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 2 files. Review in cubic

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 4, 2025
@burivuhster burivuhster requested review from a team and despairblue August 4, 2025 14:34
Copy link
Contributor

@despairblue despairblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

Copy link

currents-bot bot commented Aug 4, 2025

E2E Tests: n8n tests passed after 5m 45.2s

🟢 500 · 🔴 0 · ⚪️ 0

View Run Details

Run Details

  • Project: n8n

  • Groups: 1

  • Framework: Currents

  • Run Status: Passed

  • Commit: 2485f65

  • Spec files: 105

  • Overall tests: 500

  • Duration: 5m 45.2s

  • Parallelization: 1


This message was posted automatically by currents.dev | Integration Settings

@burivuhster burivuhster merged commit 642e68e into master Aug 4, 2025
50 checks passed
@burivuhster burivuhster deleted the ai-1257-error-cannot-read-properties-of-null-reading branch August 4, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants