fix(core): Fix some DataStore backend API issues #17978
Open
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
2 issues found across 4 files • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| default: | ||
| throw new NotFoundError(`Unsupported field type: ${type as string}`); | ||
| } | ||
| } | ||
|
|
||
| function columnToWildcardAndType(column: DataStoreCreateColumnSchema) { | ||
| return `\`${column.name}\` ${dataStoreColumnTypeToSql(column.type)}`; | ||
| return `\`${column.name}\` ${dataStoreColumnTypeToSql(column.type)}`; // Postgres identifiers use double quotes |
There was a problem hiding this comment.
Column names are quoted with back-ticks even when targeting Postgres, which requires double quotes, leading to invalid SQL at runtime (Based on your team's feedback about avoiding backend SQL mismatches).
Prompt for AI agents
Address the following comment on packages/cli/src/modules/data-store/utils/sql-utils.ts at line 29:
<comment>Column names are quoted with back-ticks even when targeting Postgres, which requires double quotes, leading to invalid SQL at runtime (Based on your team's feedback about avoiding backend SQL mismatches).</comment>
<file context>
@@ -19,14 +19,14 @@ function dataStoreColumnTypeToSql(type: DataStoreCreateColumnSchema['type']) {
case 'boolean':
return 'BOOLEAN';
case 'date':
- return 'DATETIME';
+ return 'DATETIME'; // Postgres has no DATETIME
default:
throw new NotFoundError(`Unsupported field type: ${type as string}`);
}
}
</file context>
| @@ -19,14 +19,14 @@ | |||
| case 'boolean': | |||
| return 'BOOLEAN'; | |||
| case 'date': | |||
| return 'DATETIME'; | |||
| return 'DATETIME'; // Postgres has no DATETIME | |||
There was a problem hiding this comment.
Returns DATETIME even though the comment notes the type is not supported by Postgres, so queries generated for Postgres will fail (Based on your team's feedback about catching backend SQL mismatches).
Prompt for AI agents
Address the following comment on packages/cli/src/modules/data-store/utils/sql-utils.ts at line 22:
<comment>Returns `DATETIME` even though the comment notes the type is not supported by Postgres, so queries generated for Postgres will fail (Based on your team's feedback about catching backend SQL mismatches).</comment>
<file context>
@@ -19,14 +19,14 @@ function dataStoreColumnTypeToSql(type: DataStoreCreateColumnSchema['type']) {
case 'boolean':
return 'BOOLEAN';
case 'date':
- return 'DATETIME';
+ return 'DATETIME'; // Postgres has no DATETIME
default:
throw new NotFoundError(`Unsupported field type: ${type as string}`);
</file context>
n8n-assistant
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to unblock Adore. Tests now recognize entities, but they now fail because
sql-utils.tsneeds to be made sensitive to DB type.