-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate ISR handling from IRQ processing #956
Conversation
Need to test and check the the pico SDK interrup example as well. |
Memory usage change @ 7680fa3
Click for full report table
Click for full report CSV
|
02b28c8
to
7680fa3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I tested the modification on a feather RP2040. Next, I'll swap it out for my feather ESP32-S2. That should ensure the problem stated in #939 is addressed. |
Nice looking work as usual. Just gimme some time to test, shouldn't take too long. |
Just tested well on my QtPy ESP32-S2. I had too much trouble trying to get the radio to work with my feather S2. I'm not sure if it was wiring (volt meter proved unlikely) or using the wrong pin numbers in code (pinout has 2 sets not including RTC numbers). It could have also been not enough current (the Feather S2 has 2 LDO regulators). Ultimately, I gave up and switched to my QtPy ESP32-S2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long to test, these examples are a bit complicated, but they work great.
closes #939
This basically just moves most of the ISR logic into main loop to relieve the MCU from overperforming in IRQ events.