Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the documentation for missing check_periond definition #59 #91

Closed
wants to merge 1 commit into from
Closed

Conversation

Herkum
Copy link
Contributor

@Herkum Herkum commented Jan 7, 2019

Referring to #59, when a check_period has not been defined.

This change just updates the documentation to reflect the current behavior of Naemon. Added two asterisks next to check_period, as I am unsure to say "hey, look at the documentation for this definition."

Referring to #59, when a check_period has not been defined.

This change just updates the documentation to reflect the current behavior of Naemon.  Added two asterisks next to check_period, as I am unsure to say "hey, look at the documentaiton for this definition."
@@ -323,6 +323,9 @@ This directive is used to determine whether or not passive checks are enabled fo
<td valign="top"><strong>check_period</strong>:</td>
<td>
This directive is used to specify the short name of the <a href="#timeperiod">time period</a> during which active checks of this host can be made.

{{ site.note }}If it is not defined, Naemon will check it on a <b><i>as needed basis</i></b>, which can be defined as a 24x7 time frame. This will also give a warning when running the Naemon check config command.{{ site.end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure exactly what is meant by "which can be defined as a 24x7 time frame" ?

The behavior is when check_period is 0 is documented here: http://www.naemon.org/documentation/usersguide/hostchecks.html so perhaps we could link to that page for more information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look even further back and refer to the Nagios documentation (which the core Naemon features are based upon). The check_period is 24x7, but that time period is not technically defined.

If you refer to the http://www.naemon.org/documentation/usersguide/hostchecks.html and http://www.naemon.org/documentation/usersguide/servicechecks.html does not even mention the check period, which seems to be odd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the check_period is ignored when on-demand checks are made?

Copy link
Contributor Author

@Herkum Herkum Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I recall, on-demand checks can be made outside the check_period.

I believe the check_period prevents checks from being scheduled outside the defined time frame. If there is no a time frame, it just goes ahead and schedules checks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I completely forget about this PR.

If leaving the check_period empty is the same as 24x7, then perhaps we should just write that in the object definition similar to how we have default values for other objects definitions.

@sni sni closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants