832-seaport-sales-plugin #872

Zimtente · 2025-07-14T07:24:37Z

changeset-bot · 2025-07-14T07:24:43Z

🦋 Changeset detected

Latest commit: 659913f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@ensnode/ensnode-schema	Minor
@ensnode/datasources	Minor
ensindexer	Minor
ensadmin	Minor
ensrainbow	Minor
@ensnode/ensrainbow-sdk	Minor
@ensnode/ponder-metadata	Minor
@ensnode/ponder-subgraph	Minor
@ensnode/ensnode-sdk	Minor
@ensnode/shared-configs	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-07-14T07:24:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
admin.ensnode.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2025 1:05pm
ensnode.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2025 1:05pm
ensrainbow.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2025 1:05pm

tk-o

@Zimtente very nice work 🚀 I shared some feedback, feel free to follow up.

apps/ensindexer/src/handlers/Seaport.ts

apps/ensindexer/src/lib/seaport/seaport-helpers.ts

packages/datasources/src/index.ts

…ll index Seaport-Sales across all other name-plugins we support (ENS, 3dns etc)

lightwalker-eth

@Zimtente Reviewed and shared feedback.

lightwalker-eth · 2025-08-04T12:18:59Z

packages/ensnode-schema/src/seaport.schema.ts

+import { index, onchainTable } from "ponder";
+
+const sharedEventColumns = (t: any) => ({
+  id: t.text().primaryKey(),


@Zimtente We need to document ideas like this in our code rather than in GitHub comments.

11155111-5584563-41

What are each of these values? Please document it all in detail. Thanks.

lightwalker-eth · 2025-08-04T12:26:38Z

packages/datasources/src/index.ts

@@ -217,3 +225,94 @@ export function getChainName(chainId: number): string {

  return chainName;
 }
+
+/**
+ * Returns an array of 0 or more ChainAddress objects that are known to issue tokens


Can you help me understand the motivation for noting here "... that are compatible with Seaport."?

As I understand, the goal of this function goes beyond anything Seaport-specific. This function is for all contracts known to provide tokenized name ownership within the provided namespace.

Suggested change

* Returns an array of 0 or more ChainAddress objects that are known to issue tokens

* Returns an array of 0 or more ChainAddress objects that are known to provide tokenized name ownership.

Goal: These are not just contracts that issue tokens (ex: any arbitrary token for anything at all). It's contracts that provide tokenized name ownership.

lightwalker-eth · 2025-08-04T12:29:30Z

packages/datasources/src/index.ts

+        },
+      ];
+    }
+    case ENSNamespaceIds.Holesky:


As I understand we should fill this function out as much as we can based on all the contracts we have reference to already in this datasources package, including for Holesky and the EnsTextEnv.

Please see related comment above. As I understand, this function isn't constrained only to seaport. Our indexing of sales is constrained to seaport. But this function isn't.

lightwalker-eth · 2025-08-04T12:44:21Z

apps/ensindexer/src/config/validations.ts

+  const { value: config } = ctx;
+
+  if (config.plugins.includes(PluginName.Seaport)) {
+    const nameProtocols = [


Can you please help me understand the main issue that occurs if only the Seaport plugin is activated?

What does that break? Suggest we add a comment here explaining what the issue is more specifically.

lightwalker-eth · 2025-08-04T12:46:24Z

apps/ensindexer/src/config/validations.ts

+  const { value: config } = ctx;
+
+  if (config.plugins.includes(PluginName.Seaport)) {
+    const nameProtocols = [


Not sure about calling these nameProtocols. This is an array of plugin names. We're putting great care and focus on our terminology.

It will help to better understand the deeper issue (see related comment). Appreciate your suggestion on the optimal name we can give to the ideas in this function.

lightwalker-eth · 2025-08-04T13:50:31Z

apps/ensindexer/src/lib/seaport/seaport-helpers.ts

+
+  // OLD ENS Registry: tokenId is labelhash, need to find domain by labelhash
+  if (contractAddress === baseRegistrarContractAddress) {
+    const domains = await context.db.sql.query.domain.findMany({


More broadly, I don't understand why we need to perform any DB lookup operation here at all.

If the contractAddress is the baseRegistrarContractAddress then we know the provided tokenId is a labelhash and we also know the parent name is "eth". Therefore we have all the information we need to calculate the node / namehash of the provided tokenId without any need for db operations.

This utility function should be updated such that:

Any need for db lookup operations is removed.

The context param should be removed.

The function should be moved into the datasources package. Nothing about this logic is seaport specific.

lightwalker-eth · 2025-08-04T13:55:51Z

apps/ensindexer/src/handlers/Seaport.ts

+  const totalAmount = getTotalPaymentAmount(paymentItems);
+  const currencyAddress = getPaymentTokenAddress(paymentItems);
+
+  const contractAddress = nftItem.token as Address;


Why "... as Address" here?

lightwalker-eth · 2025-08-04T13:57:51Z

packages/ensnode-schema/src/ponder.schema.ts

@@ -3,5 +3,6 @@
 */
 export * from "./subgraph.schema";
 export * from "./resolver-records.schema";
+export * from "./seaport.schema";


This is not a seaport.schema. It's a tokenscope.schema.

lightwalker-eth · 2025-08-04T13:58:19Z

packages/ensnode-schema/src/seaport.schema.ts

@@ -0,0 +1,32 @@
+import { index, onchainTable } from "ponder";


Please update the name of this file.

lightwalker-eth · 2025-08-04T13:59:52Z

packages/ensnode-schema/src/seaport.schema.ts

+    orderHash: t.hex().notNull(),
+    tokenId: t.text().notNull(),
+    contractAddress: t.hex().notNull(),
+    domainId: t.hex().notNull(),


I don't see us creating any foreign key constraints on this field. Therefore why is it needed to enforce any dependency between plugins? Please see other related comments on how we don't need db queries to build domainId.

Zimtente requested a review from a team as a code owner July 14, 2025 07:24

Zimtente linked an issue Jul 14, 2025 that may be closed by this pull request

Seaport Sales Plugin #832

Open

added seaport orderfulfill event

58e6ab0

Zimtente force-pushed the 832-seaport-sales-plugin branch from e552077 to 58e6ab0 Compare July 14, 2025 07:25

vercel bot deployed to Preview – ensnode.io July 14, 2025 07:26 View deployment

vercel bot deployed to Preview – ensrainbow.io July 14, 2025 07:26 View deployment

vercel bot deployed to Preview – admin.ensnode.io July 14, 2025 07:27 View deployment

vercel bot had a problem deploying to Preview – ensnode.io July 14, 2025 07:28 Failure

Zimtente force-pushed the 832-seaport-sales-plugin branch from f386e19 to bea6350 Compare July 14, 2025 07:29

Zimtente marked this pull request as draft July 14, 2025 07:29

vercel bot deployed to Preview – ensrainbow.io July 14, 2025 07:29 View deployment

Zimtente force-pushed the 832-seaport-sales-plugin branch from bea6350 to b493620 Compare July 14, 2025 07:30

vercel bot deployed to Preview – ensnode.io July 14, 2025 07:32 View deployment

vercel bot deployed to Preview – admin.ensnode.io July 14, 2025 07:33 View deployment

vercel bot deployed to Preview – ensrainbow.io July 14, 2025 07:34 View deployment

Zimtente force-pushed the 832-seaport-sales-plugin branch from b493620 to 6219a6c Compare July 14, 2025 08:35

vercel bot deployed to Preview – admin.ensnode.io July 14, 2025 08:38 View deployment

vercel bot deployed to Preview – ensrainbow.io July 14, 2025 08:38 View deployment

vercel bot deployed to Preview – ensnode.io July 14, 2025 08:39 View deployment

Zimtente force-pushed the 832-seaport-sales-plugin branch from 6219a6c to 8dbc1d6 Compare July 14, 2025 08:44

vercel bot deployed to Preview – ensrainbow.io July 14, 2025 08:45 View deployment

vercel bot deployed to Preview – admin.ensnode.io July 14, 2025 08:46 View deployment

vercel bot deployed to Preview – ensnode.io July 14, 2025 08:46 View deployment

Zimtente force-pushed the 832-seaport-sales-plugin branch from 8dbc1d6 to 91f1088 Compare July 14, 2025 08:53

vercel bot deployed to Preview – admin.ensnode.io July 14, 2025 08:54 View deployment

vercel bot deployed to Preview – ensnode.io July 14, 2025 08:55 View deployment

vercel bot deployed to Preview – ensrainbow.io July 14, 2025 08:55 View deployment

Zimtente changed the title ~~added seaport orderfulfill event~~ 832-seaport-sales-plugin Jul 14, 2025

vercel bot deployed to Preview – ensrainbow.io July 28, 2025 06:21 View deployment

vercel bot deployed to Preview – admin.ensnode.io July 28, 2025 06:22 View deployment

vercel bot deployed to Preview – ensnode.io July 28, 2025 06:23 View deployment

tk-o reviewed Jul 28, 2025

View reviewed changes

Zimtente force-pushed the 832-seaport-sales-plugin branch from 1c667ae to bdac09a Compare July 28, 2025 13:34

vercel bot deployed to Preview – admin.ensnode.io July 28, 2025 13:35 View deployment

Zimtente force-pushed the 832-seaport-sales-plugin branch from bdac09a to b3302d6 Compare July 28, 2025 13:36

vercel bot deployed to Preview – ensnode.io July 28, 2025 13:37 View deployment

vercel bot deployed to Preview – ensrainbow.io July 28, 2025 13:37 View deployment

Zimtente requested a review from lightwalker-eth July 28, 2025 13:38

vercel bot deployed to Preview – admin.ensnode.io July 28, 2025 13:38 View deployment

Zimtente force-pushed the 832-seaport-sales-plugin branch from b3302d6 to edfdfb8 Compare August 4, 2025 12:27

vercel bot deployed to Preview – ensrainbow.io August 4, 2025 12:28 View deployment

vercel bot deployed to Preview – admin.ensnode.io August 4, 2025 12:29 View deployment

vercel bot deployed to Preview – ensnode.io August 4, 2025 12:30 View deployment

Merge branch 'main' into 832-seaport-sales-plugin

9d6fae4

Zimtente force-pushed the 832-seaport-sales-plugin branch from edfdfb8 to 9d6fae4 Compare August 4, 2025 12:51

vercel bot deployed to Preview – admin.ensnode.io August 4, 2025 12:53 View deployment

vercel bot deployed to Preview – ensnode.io August 4, 2025 12:53 View deployment

vercel bot deployed to Preview – ensrainbow.io August 4, 2025 12:54 View deployment

docs(changeset): Added new Plugin: TokenScope. This Plugin for now wi…

f8433f1

…ll index Seaport-Sales across all other name-plugins we support (ENS, 3dns etc)

Zimtente force-pushed the 832-seaport-sales-plugin branch from 4c3fab3 to f8433f1 Compare August 4, 2025 12:56

vercel bot deployed to Preview – ensrainbow.io August 4, 2025 12:57 View deployment

vercel bot deployed to Preview – ensnode.io August 4, 2025 12:58 View deployment

vercel bot deployed to Preview – admin.ensnode.io August 4, 2025 13:00 View deployment

Merge branch 'main' into 832-seaport-sales-plugin

659913f

vercel bot deployed to Preview – ensrainbow.io August 4, 2025 13:03 View deployment

vercel bot deployed to Preview – ensnode.io August 4, 2025 13:04 View deployment

vercel bot deployed to Preview – admin.ensnode.io August 4, 2025 13:05 View deployment

lightwalker-eth requested changes Aug 4, 2025

View reviewed changes

	* Returns an array of 0 or more ChainAddress objects that are known to issue tokens
	* Returns an array of 0 or more ChainAddress objects that are known to provide tokenized name ownership.

		@@ -0,0 +1,32 @@
		import { index, onchainTable } from "ponder";

832-seaport-sales-plugin #872

Are you sure you want to change the base?

832-seaport-sales-plugin #872

Uh oh!

Conversation

Zimtente commented Jul 14, 2025

Uh oh!

changeset-bot bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tk-o left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Jul 14, 2025 •

edited

Loading

vercel bot commented Jul 14, 2025 •

edited

Loading