Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon lua docs update and optimising the minimizer when theres no minimizer options enabled. #128

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Toast732
Copy link
Contributor

  • Updates Addon lua docs to be up to date with v1.9
  • Made the UI_ID it's own type, that way when people try hardcoding a number with it, it will give them a warning, the reason for doing this is because hardcoding a UI_ID is very bad practice, and is bound to start having issues when another addon is assigned that ui_id, and the two addons start fighting over the ID.
  • Optimised the minimizer when theres no minimizer options selected, I did this as I was getting bored of constantly waiting 20-30s when building addons such as Improved Conquest Mode and Improved Missions and AI, and found that by skipping all of the code, heavily reduced the amount of time needed to wait.
  • Also implemented the same fix that @OER1057 did, but shouldn't be added with this PR, sorry haha, didn't know you already solved the issue, where the 200 local variable limit in lua would result in you being limited to 64 files, I ended up hitting 65 files with IMAI.

- Optimised the minimizer when there are no minimizer options enabled (from 20-30s build time on ICM to 0.5s)
- Fixed issue where you would be limited to 64 files, due to the variables put in _build.lua for each file being local, resulting in the 200 local variable limit lua has being hit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant