misc: Improve and amend bash completion feature #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved issues with the current bash-completion.sh script: 1. Options are now properly listed, starting with "-" or "--". 2. Files from the current directory and subcommands are no longer incorrectly included in the completion listing. Fixed: namhyung#873 Signed-off-by: Hyunho Cho <[email protected]> Signed-off-by: Kang Minchul <[email protected]>
Adjusted the `configure` script for improved quoting and proper handling of bash completion directory based on `pkg-config` detection. The recommended directory is completionsdir, which can be obtained like below [1]: $ pkg-config --variable=completionsdir bash-completion [1] https://github.com/scop/bash-completion#faq Signed-off-by: Kang Minchul <[email protected]>
kangtegong
changed the title
kangtegong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and modifies the bash completion feature,
by appling patch from @mug896 and relocate bash completion script path based on
pkg-config.This PR makes bash completion feature works correctly
even when installed with the
--prefixas follows.For your information, the bash completion feature does not apply immediately after the installation,
but apply immediately after
sourceor after terminal is refreshed.