utils: hashmap: Add RISC-V 64-bit support in ARCH64 check #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namhyung
reviewed
Sep 8, 2025
utils/hashmap.h
Outdated
| #include <stdlib.h> | ||
|
|
||
| #if defined(__amd64__) || defined(__aarch64__) | ||
| #if defined(__amd64__) || defined(__aarch64__) || (defined(__riscv) && __riscv_xlen == 64) |
There was a problem hiding this comment.
Can we have more general check like below?
#if __SIZEOF_POINTER__ == 8
There was a problem hiding this comment.
Thank you Namhyung, for the review! How about this?
#if __SIZEOF_POINTER__ >= 8
The hashmap implementation currently defines ARCH64 only for amd64 and aarch64, and now also checks for 64-bit RISC-V by checking __SIZEOF_POINTER__. This enables uftrace to correctly detect 64-bit RISC-V user programs and apply the appropriate word size. Signed-off-by: Yunseong Kim <[email protected]>
kzall0c
force-pushed
the
riscv64-macro
branch
from
1c37a04 to
9b5f84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashmap implementation currently defines ARCH64 only for amd64 and aarch64, and now also checks for 64-bit RISC-V by checking __riscv with __riscv_xlen == 64.
This enables uftrace to correctly detect 64-bit RISC-V user programs and apply the appropriate word size.