Skip to content

Commit 305b860

Browse files
committed
Merge branch 'ar/docs-tweaks' into 'master'
Adds summary table to intro. See merge request machine-learning/modkit!45
2 parents fc90729 + a3af05e commit 305b860

File tree

8 files changed

+81
-20
lines changed

8 files changed

+81
-20
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
A bioinformatics tool for working with modified bases from Oxford Nanopore. Specifically for converting modBAM
66
to bedMethyl files using best practices, but also manipulating modBAM files and generating summary statistics.
7-
Detailed documentation and quick-start can be found in the [online docs](https://nanoporetech.github.io/modkit/).
7+
Detailed documentation and quick-start can be found in the [online documentation](https://nanoporetech.github.io/modkit/).
88

99
## Installation
1010

@@ -111,7 +111,7 @@ CG->CH substitution such that no modification call was produced by the basecalle
111111
| 13 | N<sub>canonical</sub> | See definitions above. | int |
112112
| 14 | N<sub>other_mod</sub> | See definitions above. | int |
113113
| 15 | N<sub>delete</sub> | See definitions above. | int |
114-
| 16 | N<sub>filtered</sub> | See definitions above. | int |
114+
| 16 | N<sub>fail</sub> | See definitions above. | int |
115115
| 17 | N<sub>diff</sub> | See definitions above. | int |
116116
| 18 | N<sub>nocall</sub> | See definitions above. | int |
117117

@@ -134,10 +134,10 @@ The modification calls table follows immediately after the totals table.
134134
|--------|------------|------------------------------------------------------------------------------------------|-------|
135135
| 1 | base | canonical base with modification call | char |
136136
| 2 | code | base modification code, or `-` for canonical | char |
137-
| 3 | all_count | total number of calls for the modification code in column 2 | int |
138-
| 4 | all_frac | fraction of all calls for the modification in column 2 | float |
139-
| 5 | pass_count | total number of passing (confidence >= threshold) calls for the modification in column 2 | int |
140-
| 6 | pass_frac | fraction of passing (>= threshold) calls for the modification in column 2 | float |
137+
| 3 | pass_count | total number of passing (confidence >= threshold) calls for the modification in column 2 | int |
138+
| 4 | pass_frac | fraction of passing (>= threshold) calls for the modification in column 2 | float |
139+
| 5 | all_count | total number of calls for the modification code in column 2 | int |
140+
| 6 | all_frac | fraction of all calls for the modification in column 2 | float |
141141

142142

143143

book/src/intro_bedmethyl.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ CG->CH substitution such that no modification call was produced by the basecalle
9494
| 13 | N<sub>canonical</sub> | See definitions above. | int |
9595
| 14 | N<sub>other_mod</sub> | See definitions above. | int |
9696
| 15 | N<sub>delete</sub> | See definitions above. | int |
97-
| 16 | N<sub>filtered</sub> | See definitions above. | int |
97+
| 16 | N<sub>fail</sub> | See definitions above. | int |
9898
| 17 | N<sub>diff</sub> | See definitions above. | int |
9999
| 18 | N<sub>nocall</sub> | See definitions above. | int |
100100

book/src/intro_summary.md

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,32 @@ will output a table similar to this
2727
C - 718543 0.3537855 754087 0.33435062
2828
```
2929

30-
The `pass_count` and `pass_frac` columns are the statistics for calls with confidence
31-
greater than or equal to the `pass_threshold` for that canonical base's calls. For more
32-
details on thresholds see [filtering base modification calls](./filtering.md).
30+
## Description of columns in `modkit summary`:
31+
### Totals table
32+
The lines of the totals table are prefixed with a `#` character.
33+
34+
| row | name | description | type |
35+
|-----|-------------------------|-------------------------------------------------------------------------|--------|
36+
| 1 | bases | comma-separated list of canonical bases with modification calls. | str |
37+
| 2 | total_reads_used | total number of reads from which base modification calls were extracted | int |
38+
| 3+ | count_reads_{base} | total number of reads that contained base modifications for {base} | int |
39+
| 4+ | filter_threshold_{base} | filter threshold used for {base} | float |
40+
41+
### Modification calls table
42+
The modification calls table follows immediately after the totals table.
43+
44+
| column | name | description | type |
45+
|--------|------------|------------------------------------------------------------------------------------------|-------|
46+
| 1 | base | canonical base with modification call | char |
47+
| 2 | code | base modification code, or `-` for canonical | char |
48+
| 3 | pass_count | total number of passing (confidence >= threshold) calls for the modification in column 2 | int |
49+
| 4 | pass_frac | fraction of passing (>= threshold) calls for the modification in column 2 | float |
50+
| 5 | all_count | total number of calls for the modification code in column 2 | int |
51+
| 6 | all_frac | fraction of all calls for the modification in column 2 | float |
52+
53+
54+
For more details on thresholds see [filtering base modification calls](./filtering.md).
55+
3356

3457
By default `modkit summary` will only use ten thousand reads when generating the summary
3558
(or fewer if the modBAM has fewer than that). To use all of the reads in the modBAM set

docs/intro_bedmethyl.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ <h3 id="bedmethyl-column-descriptions"><a class="header" href="#bedmethyl-column
223223
<tr><td>13</td><td>N<sub>canonical</sub></td><td>See definitions above.</td><td>int</td></tr>
224224
<tr><td>14</td><td>N<sub>other_mod</sub></td><td>See definitions above.</td><td>int</td></tr>
225225
<tr><td>15</td><td>N<sub>delete</sub></td><td>See definitions above.</td><td>int</td></tr>
226-
<tr><td>16</td><td>N<sub>filtered</sub></td><td>See definitions above.</td><td>int</td></tr>
226+
<tr><td>16</td><td>N<sub>fail</sub></td><td>See definitions above.</td><td>int</td></tr>
227227
<tr><td>17</td><td>N<sub>diff</sub></td><td>See definitions above.</td><td>int</td></tr>
228228
<tr><td>18</td><td>N<sub>nocall</sub></td><td>See definitions above.</td><td>int</td></tr>
229229
</tbody></table>

docs/intro_summary.html

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,28 @@ <h2 id="summarize-the-base-modification-calls-in-a-modbam"><a class="header" hre
168168
C h 119937 0.0590528 195335 0.086608544
169169
C - 718543 0.3537855 754087 0.33435062
170170
</code></pre>
171-
<p>The <code>pass_count</code> and <code>pass_frac</code> columns are the statistics for calls with confidence
172-
greater than or equal to the <code>pass_threshold</code> for that canonical base's calls. For more
173-
details on thresholds see <a href="./filtering.html">filtering base modification calls</a>.</p>
171+
<h2 id="description-of-columns-in-modkit-summary"><a class="header" href="#description-of-columns-in-modkit-summary">Description of columns in <code>modkit summary</code>:</a></h2>
172+
<h3 id="totals-table"><a class="header" href="#totals-table">Totals table</a></h3>
173+
<p>The lines of the totals table are prefixed with a <code>#</code> character.</p>
174+
<div class="table-wrapper"><table><thead><tr><th>row</th><th>name</th><th>description</th><th>type</th></tr></thead><tbody>
175+
<tr><td>1</td><td>bases</td><td>comma-separated list of canonical bases with modification calls.</td><td>str</td></tr>
176+
<tr><td>2</td><td>total_reads_used</td><td>total number of reads from which base modification calls were extracted</td><td>int</td></tr>
177+
<tr><td>3+</td><td>count_reads_{base}</td><td>total number of reads that contained base modifications for {base}</td><td>int</td></tr>
178+
<tr><td>4+</td><td>filter_threshold_{base}</td><td>filter threshold used for {base}</td><td>float</td></tr>
179+
</tbody></table>
180+
</div>
181+
<h3 id="modification-calls-table"><a class="header" href="#modification-calls-table">Modification calls table</a></h3>
182+
<p>The modification calls table follows immediately after the totals table.</p>
183+
<div class="table-wrapper"><table><thead><tr><th>column</th><th>name</th><th>description</th><th>type</th></tr></thead><tbody>
184+
<tr><td>1</td><td>base</td><td>canonical base with modification call</td><td>char</td></tr>
185+
<tr><td>2</td><td>code</td><td>base modification code, or <code>-</code> for canonical</td><td>char</td></tr>
186+
<tr><td>3</td><td>pass_count</td><td>total number of passing (confidence &gt;= threshold) calls for the modification in column 2</td><td>int</td></tr>
187+
<tr><td>4</td><td>pass_frac</td><td>fraction of passing (&gt;= threshold) calls for the modification in column 2</td><td>float</td></tr>
188+
<tr><td>5</td><td>all_count</td><td>total number of calls for the modification code in column 2</td><td>int</td></tr>
189+
<tr><td>6</td><td>all_frac</td><td>fraction of all calls for the modification in column 2</td><td>float</td></tr>
190+
</tbody></table>
191+
</div>
192+
<p>For more details on thresholds see <a href="./filtering.html">filtering base modification calls</a>.</p>
174193
<p>By default <code>modkit summary</code> will only use ten thousand reads when generating the summary
175194
(or fewer if the modBAM has fewer than that). To use all of the reads in the modBAM set
176195
the <code>--no-sampling</code> flag.</p>

docs/print.html

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ <h3 id="bedmethyl-column-descriptions"><a class="header" href="#bedmethyl-column
249249
<tr><td>13</td><td>N<sub>canonical</sub></td><td>See definitions above.</td><td>int</td></tr>
250250
<tr><td>14</td><td>N<sub>other_mod</sub></td><td>See definitions above.</td><td>int</td></tr>
251251
<tr><td>15</td><td>N<sub>delete</sub></td><td>See definitions above.</td><td>int</td></tr>
252-
<tr><td>16</td><td>N<sub>filtered</sub></td><td>See definitions above.</td><td>int</td></tr>
252+
<tr><td>16</td><td>N<sub>fail</sub></td><td>See definitions above.</td><td>int</td></tr>
253253
<tr><td>17</td><td>N<sub>diff</sub></td><td>See definitions above.</td><td>int</td></tr>
254254
<tr><td>18</td><td>N<sub>nocall</sub></td><td>See definitions above.</td><td>int</td></tr>
255255
</tbody></table>
@@ -316,9 +316,28 @@ <h2 id="summarize-the-base-modification-calls-in-a-modbam"><a class="header" hre
316316
C h 119937 0.0590528 195335 0.086608544
317317
C - 718543 0.3537855 754087 0.33435062
318318
</code></pre>
319-
<p>The <code>pass_count</code> and <code>pass_frac</code> columns are the statistics for calls with confidence
320-
greater than or equal to the <code>pass_threshold</code> for that canonical base's calls. For more
321-
details on thresholds see <a href="./filtering.html">filtering base modification calls</a>.</p>
319+
<h2 id="description-of-columns-in-modkit-summary"><a class="header" href="#description-of-columns-in-modkit-summary">Description of columns in <code>modkit summary</code>:</a></h2>
320+
<h3 id="totals-table"><a class="header" href="#totals-table">Totals table</a></h3>
321+
<p>The lines of the totals table are prefixed with a <code>#</code> character.</p>
322+
<div class="table-wrapper"><table><thead><tr><th>row</th><th>name</th><th>description</th><th>type</th></tr></thead><tbody>
323+
<tr><td>1</td><td>bases</td><td>comma-separated list of canonical bases with modification calls.</td><td>str</td></tr>
324+
<tr><td>2</td><td>total_reads_used</td><td>total number of reads from which base modification calls were extracted</td><td>int</td></tr>
325+
<tr><td>3+</td><td>count_reads_{base}</td><td>total number of reads that contained base modifications for {base}</td><td>int</td></tr>
326+
<tr><td>4+</td><td>filter_threshold_{base}</td><td>filter threshold used for {base}</td><td>float</td></tr>
327+
</tbody></table>
328+
</div>
329+
<h3 id="modification-calls-table"><a class="header" href="#modification-calls-table">Modification calls table</a></h3>
330+
<p>The modification calls table follows immediately after the totals table.</p>
331+
<div class="table-wrapper"><table><thead><tr><th>column</th><th>name</th><th>description</th><th>type</th></tr></thead><tbody>
332+
<tr><td>1</td><td>base</td><td>canonical base with modification call</td><td>char</td></tr>
333+
<tr><td>2</td><td>code</td><td>base modification code, or <code>-</code> for canonical</td><td>char</td></tr>
334+
<tr><td>3</td><td>pass_count</td><td>total number of passing (confidence &gt;= threshold) calls for the modification in column 2</td><td>int</td></tr>
335+
<tr><td>4</td><td>pass_frac</td><td>fraction of passing (&gt;= threshold) calls for the modification in column 2</td><td>float</td></tr>
336+
<tr><td>5</td><td>all_count</td><td>total number of calls for the modification code in column 2</td><td>int</td></tr>
337+
<tr><td>6</td><td>all_frac</td><td>fraction of all calls for the modification in column 2</td><td>float</td></tr>
338+
</tbody></table>
339+
</div>
340+
<p>For more details on thresholds see <a href="./filtering.html">filtering base modification calls</a>.</p>
322341
<p>By default <code>modkit summary</code> will only use ten thousand reads when generating the summary
323342
(or fewer if the modBAM has fewer than that). To use all of the reads in the modBAM set
324343
the <code>--no-sampling</code> flag.</p>

docs/searchindex.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/searchindex.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)