Skip to content

Commit 66b792a

Browse files
committed
Merge branch 'gpimm/numpy_2.0' into 'master'
update to numpy 2.0 See merge request minknow/pod5-file-format!347
2 parents dcb2c42 + ddfa729 commit 66b792a

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
## Added
1313

1414
- Typechecking on `Writer.add_reads` to inform users incorrectly passing `ReadRecords`
15+
- Compatibility with numpy 2.0.
1516

1617
## Fixed
1718

c++/pod5_format_pybind/api.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ class Pod5SignalCacheBatch {
6565
return py_samples;
6666
}
6767
for (auto const & row_samples : m_cached_data.samples()) {
68-
py_samples.append(py::array_t<std::int16_t>(row_samples.size(), row_samples.data()));
68+
py_samples.append(py::array_t<std::int16_t>(
69+
{row_samples.size()}, {sizeof(std::int16_t)}, row_samples.data()));
6970
}
7071

7172
return py_samples;

python/pod5/pyproject.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,12 @@ dependencies = [
2828
"more_itertools",
2929
"numpy >= 1.21.0",
3030
'typing-extensions; python_version<"3.8"',
31-
"pyarrow ~= 14.0.0",
31+
"pyarrow ~= 16.1.0",
3232
"pytz",
3333
"packaging",
3434
"polars~=0.19",
35-
"h5py~=3.10.0",
35+
'h5py~=3.11.0; python_version>"3.8"',
36+
'h5py~=3.10.0; python_version<="3.8"',
3637
"vbz_h5py_plugin",
3738
"tqdm"
3839
]

0 commit comments

Comments
 (0)