Merge branch 'gpimm/INSTX-11836_tweak_tmp_file_naming' into 'master'

INSTX-11836 Tidying pod5 naming

Closes INSTX-11836

See merge request minknow/pod5-file-format!439

Author: 0x55555555

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Fixed migration behaviour on nfs systems, where migrated tables could be left orphaned on disk.
 - Limited polars install version to "~=1.20,<1.32" following breaking changes
+- Tidied up how tmp files are named, used a larger set of numbers for naming.
 
 ## [0.3.33]
 

c++/pod5_format/migration/migration.cpp

@@ -6,14 +6,13 @@ namespace pod5 {
 
 Result<std::unique_ptr<TemporaryDir>> MakeTmpDir(char const * suffix)
 {
-    std::uint32_t counter = 0;
-    while (counter < 3) {
+    std::default_random_engine gen(
+        static_cast<std::default_random_engine::result_type>(arrow::internal::GetRandomSeed()));
+
+    for (std::uint32_t counter = 0; counter < 5; ++counter) {
         std::string tmp_path = std::string{".tmp_"} + suffix;
 
-        std::default_random_engine gen(
-            static_cast<std::default_random_engine::result_type>(arrow::internal::GetRandomSeed()));
-        std::uniform_int_distribution<int> dist(0, 1024);
-        tmp_path += "_" + std::to_string(dist(gen));
+        tmp_path += "_" + std::to_string(gen());
 
         ARROW_ASSIGN_OR_RAISE(
             auto filename, arrow::internal::PlatformFilename::FromString(tmp_path));